From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36260EB64DB for ; Wed, 14 Jun 2023 06:26:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A599885F50; Wed, 14 Jun 2023 08:25:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Cz/1T3nv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B83D985F3D; Wed, 14 Jun 2023 08:25:55 +0200 (CEST) Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 33CD9847D5 for ; Wed, 14 Jun 2023 08:25:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ganboing@gmail.com Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-65055aa4ed7so5042553b3a.3 for ; Tue, 13 Jun 2023 23:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686723951; x=1689315951; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=QNAX1e2QDVVP9LcnbKjEMN/YQ8Km3wA1F52aju7g4Vg=; b=Cz/1T3nvdyCnuLb8OhDgUqrbMTPZEVhJcvyn5vy3AwPcUFGTHR3Qxx6Mosr/wfG+Yb 9/gju48H35P7sTmWg9jQT3790ojspUHNuhFH7nRwJzOubu0jGuLs3PJoEskirhusIiBh /ESUp2tKzocBs+xN63u9oiRIqZjGPSug+AMoA+6FNNfbaxO+GqCompAlUvwpfPcj1w2/ WstIlhAgtKzJ+jFe7rGtLDLZcXsuLFpeUAyTY/IKlXCwUN+N9B/KwWW7uYzw+gAhyOg3 eclSuGilFHaxwK9z14SG7HE2gTYDVSVJYQVWSNtvN014ey2Hg8wtRlyNTJFLRve3Hn35 8VRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686723951; x=1689315951; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QNAX1e2QDVVP9LcnbKjEMN/YQ8Km3wA1F52aju7g4Vg=; b=XaOCAm15rkvxZ7J0fxJZHWV24mobF2Na+1EQM14gnJA/8wGb9SfkNSux7d8oJ5NxL5 YvJo7iV0fBIwfePrw7mBUckpyJueMJ7CtJEymBKrSlqEUhOlB6urfaBEyrLGhuX2SLqe sKZmjEGeohBRJMEwJQs6MyWQMdzAuP5MjN3HzO7vk2Ic7zeKNvEssMxFB2sCidmGE5nw 9TsH5ZFZy7i63qvk5FiK9E/jkhQI5g6pzMYd2GYezDp8i8XYSEkKufhxUrHWbUa9KDv6 D8t1zzpiUqu7E/CFim4LGM2pPkLRWTK0jPXpwAZ8Oy5VDwRPJ/exqKdbye5ahy+7oEJ9 iT8w== X-Gm-Message-State: AC+VfDwmCkRxlsV32xGF6IS9po8i8COaIXIpnpHNz658NqxqKvpRbspb x7gebsK4LIrXIBu70WvFWlc= X-Google-Smtp-Source: ACHHUZ7pee1H7gIc2sGwqF9wmTn5Yi8mihisbdtUJSYrI3tKpDWiQQdNUocwlWWC9b9AWz44mMOBPg== X-Received: by 2002:a05:6a00:39a3:b0:634:7ba3:d142 with SMTP id fi35-20020a056a0039a300b006347ba3d142mr1148677pfb.10.1686723951393; Tue, 13 Jun 2023 23:25:51 -0700 (PDT) Received: from [192.168.0.13] ([172.92.174.136]) by smtp.gmail.com with ESMTPSA id p2-20020aa78602000000b00634b91326a9sm2331640pfn.143.2023.06.13.23.25.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 23:25:50 -0700 (PDT) Subject: Re: [PATCH] riscv: add backtrace support To: Ben Dooks , Ben Dooks , u-boot@lists.denx.de Cc: rick@andestech.com References: <20230515130322.516871-1-ben.dooks@sifive.com> <32369479-7490-f437-4c12-3250476d1862@codethink.co.uk> From: Bo Gan Message-ID: Date: Tue, 13 Jun 2023 23:25:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <32369479-7490-f437-4c12-3250476d1862@codethink.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 5/25/23 4:05 AM, Ben Dooks wrote: > On 15/05/2023 14:03, Ben Dooks wrote: >> When debugging, it is useful to have a backtrace to find >> out what is in the call stack as the previous function (RA) >> may not have been the culprit. >> >> Since this adds size to the build, do not add it by default >> and avoid putting it in the SPL build if not needed. > > Hi, has anyone had time to review this? > Hi Ben, this looks really useful. I'd like to use it in SPL, but I'm unable to enable CONFIG_SPL_FRAMEPOINTER=y. It's likely that you need to add a SPL_FRAMEPOINTER entry to Kconfig as well.