Re: [PATCH v3 2/4] misc: ele_api: Add support for XSPI SET GMID command

[Peng Fan <peng.fan@oss.nxp.com>]

On Tue, Mar 03, 2026 at 09:10:27AM +0800, alice.guo@oss.nxp.com wrote:
>From: Ye Li <ye.li@nxp.com>
>
>The XSPI SET GMID command is used to assign GMID ownership to the
>requester, allowing access to protected XSPI control registers. This API
>must be called in SPL if XSPI GMID-protected settings need to be
>modified. Otherwise, XSPI configuration depends on the previous GMID
>owner to provide the correct settings.
>
>Signed-off-by: Ye Li <ye.li@nxp.com>
>Signed-off-by: Alice Guo <alice.guo@nxp.com>
>---
> arch/arm/include/asm/mach-imx/ele_api.h |  2 ++
> drivers/misc/imx_ele/ele_api.c          | 28 ++++++++++++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
>diff --git a/arch/arm/include/asm/mach-imx/ele_api.h b/arch/arm/include/asm/mach-imx/ele_api.h
>index 4e1afc42bd8..04e7f20a2a6 100644
>--- a/arch/arm/include/asm/mach-imx/ele_api.h
>+++ b/arch/arm/include/asm/mach-imx/ele_api.h
>@@ -49,6 +49,7 @@
> #define ELE_ATTEST_REQ (0xDB)
> #define ELE_RELEASE_PATCH_REQ (0xDC)
> #define ELE_OTP_SEQ_SWITH_REQ (0xDD)
>+#define ELE_SET_GMID_REQ (0xE4)
> #define ELE_WRITE_SHADOW_REQ (0xF2)
> #define ELE_READ_SHADOW_REQ (0xF3)

We should drop (), but to keep code consistent, it is fine here.

> 
>@@ -162,6 +163,7 @@ int ele_return_lifecycle_update(ulong signed_msg_blk, u32 *response);
> int ele_start_rng(void);
[...]
>+		printf("Error: %s: ret %d, response 0x%x\n",
>+		       __func__, ret, msg.data[0]);
>+
>+	if (response)
>+		*response = msg.data[0];
>+
>+	return ret;
>+}


Reviewed-by: Peng Fan <peng.fan@nxp.com>

>
>-- 
>2.43.0
>