* [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID
@ 2022-04-24 21:39 Marek Vasut
2022-04-25 4:39 ` Stefan Roese
2022-05-17 13:38 ` Tudor.Ambarus
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2022-04-24 21:39 UTC (permalink / raw)
To: u-boot
Cc: Marek Vasut, Horatiu Vultur, Jagan Teki, Simon Goldschmidt,
Stefan Roese, Vignesh R
Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR.
Tested on W25Q128JWPIM part.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Cc: Stefan Roese <sr@denx.de>
Cc: Vignesh R <vigneshr@ti.com>
---
NOTE: This has been incorrectly marked in PW as Changes Requested
---
drivers/mtd/spi/spi-nor-ids.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 763bab04c60..393a24b3162 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -345,6 +345,11 @@ const struct flash_info spi_nor_ids[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
},
+ {
+ INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ },
{
INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID
2022-04-24 21:39 [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID Marek Vasut
@ 2022-04-25 4:39 ` Stefan Roese
2022-05-09 12:40 ` Marek Vasut
2022-05-17 13:38 ` Tudor.Ambarus
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2022-04-25 4:39 UTC (permalink / raw)
To: Marek Vasut, u-boot
Cc: Horatiu Vultur, Jagan Teki, Simon Goldschmidt, Vignesh R
On 4/24/22 23:39, Marek Vasut wrote:
> Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR.
> Tested on W25Q128JWPIM part.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vignesh R <vigneshr@ti.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> NOTE: This has been incorrectly marked in PW as Changes Requested
> ---
> drivers/mtd/spi/spi-nor-ids.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 763bab04c60..393a24b3162 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -345,6 +345,11 @@ const struct flash_info spi_nor_ids[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> },
> + {
> + INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + },
> {
> INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID
2022-04-25 4:39 ` Stefan Roese
@ 2022-05-09 12:40 ` Marek Vasut
2022-05-16 19:51 ` Marek Vasut
2022-05-17 15:35 ` Jagan Teki
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2022-05-09 12:40 UTC (permalink / raw)
To: Stefan Roese, u-boot
Cc: Horatiu Vultur, Jagan Teki, Simon Goldschmidt, Vignesh R
On 4/25/22 06:39, Stefan Roese wrote:
> On 4/24/22 23:39, Marek Vasut wrote:
>> Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR.
>> Tested on W25Q128JWPIM part.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
>> Cc: Jagan Teki <jagan@amarulasolutions.com>
>> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>> Cc: Stefan Roese <sr@denx.de>
>> Cc: Vignesh R <vigneshr@ti.com>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
Can this be applied soon ?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID
2022-05-09 12:40 ` Marek Vasut
@ 2022-05-16 19:51 ` Marek Vasut
2022-05-17 15:35 ` Jagan Teki
1 sibling, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2022-05-16 19:51 UTC (permalink / raw)
To: Stefan Roese, u-boot
Cc: Horatiu Vultur, Jagan Teki, Simon Goldschmidt, Vignesh R,
Tom Rini
On 5/9/22 14:40, Marek Vasut wrote:
> On 4/25/22 06:39, Stefan Roese wrote:
>> On 4/24/22 23:39, Marek Vasut wrote:
>>> Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR.
>>> Tested on W25Q128JWPIM part.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
>>> Cc: Jagan Teki <jagan@amarulasolutions.com>
>>> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>>> Cc: Stefan Roese <sr@denx.de>
>>> Cc: Vignesh R <vigneshr@ti.com>
>>
>> Reviewed-by: Stefan Roese <sr@denx.de>
>
> Can this be applied soon ?
+CC Tom , can you pick this ?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID
2022-04-24 21:39 [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID Marek Vasut
2022-04-25 4:39 ` Stefan Roese
@ 2022-05-17 13:38 ` Tudor.Ambarus
1 sibling, 0 replies; 6+ messages in thread
From: Tudor.Ambarus @ 2022-05-17 13:38 UTC (permalink / raw)
To: marex, u-boot; +Cc: Horatiu.Vultur, jagan, simon.k.r.goldschmidt, sr, vigneshr
On 4/25/22 00:39, Marek Vasut wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR.
> Tested on W25Q128JWPIM part.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vignesh R <vigneshr@ti.com>
> ---
> NOTE: This has been incorrectly marked in PW as Changes Requested
> ---
> drivers/mtd/spi/spi-nor-ids.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 763bab04c60..393a24b3162 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -345,6 +345,11 @@ const struct flash_info spi_nor_ids[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> },
> + {
> + INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,
We can update the name later on if needed, so:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + },
> {
> INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID
2022-05-09 12:40 ` Marek Vasut
2022-05-16 19:51 ` Marek Vasut
@ 2022-05-17 15:35 ` Jagan Teki
1 sibling, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2022-05-17 15:35 UTC (permalink / raw)
To: Marek Vasut
Cc: Stefan Roese, u-boot, Horatiu Vultur, Simon Goldschmidt,
Vignesh R
On Mon, May 9, 2022 at 6:10 PM Marek Vasut <marex@denx.de> wrote:
>
> On 4/25/22 06:39, Stefan Roese wrote:
> > On 4/24/22 23:39, Marek Vasut wrote:
> >> Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR.
> >> Tested on W25Q128JWPIM part.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> >> Cc: Jagan Teki <jagan@amarulasolutions.com>
> >> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> >> Cc: Stefan Roese <sr@denx.de>
> >> Cc: Vignesh R <vigneshr@ti.com>
> >
> > Reviewed-by: Stefan Roese <sr@denx.de>
>
> Can this be applied soon ?
This is already merged.
https://patchwork.ozlabs.org/project/uboot/patch/20220504061108.4949-1-jagan@amarulasolutions.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-17 15:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-24 21:39 [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID Marek Vasut
2022-04-25 4:39 ` Stefan Roese
2022-05-09 12:40 ` Marek Vasut
2022-05-16 19:51 ` Marek Vasut
2022-05-17 15:35 ` Jagan Teki
2022-05-17 13:38 ` Tudor.Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox