From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schwierzeck Date: Thu, 23 Apr 2020 19:52:25 +0200 Subject: [PATCH 2/7] examples: rename __start to _start on MIPS In-Reply-To: <20200420223418.117186-3-mhorne@FreeBSD.org> References: <20200420223418.117186-1-mhorne@FreeBSD.org> <20200420223418.117186-3-mhorne@FreeBSD.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de +cc Wolfgang, Tom Am 21.04.20 um 00:34 schrieb mhorne at FreeBSD.org: > From: Mitchell Horne > > On MIPS, __start marks the entry point to the CONFIG_API demo program. > Change the name to _start, to be consistent with all other > architectures. > > Signed-off-by: Mitchell Horne > --- > examples/api/crt0.S | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/examples/api/crt0.S b/examples/api/crt0.S > index 57bba9d851..2f75f5a036 100644 > --- a/examples/api/crt0.S > +++ b/examples/api/crt0.S > @@ -42,12 +42,12 @@ syscall: > #elif defined(CONFIG_MIPS) > #include > .text > - .globl __start > - .ent __start > -__start: > + .globl _start > + .ent _start > +_start: > PTR_S $sp, search_hint > b main > - .end __start > + .end _start > > .globl syscall > .ent syscall > __start is used by the default binutils linker script for MIPS. For a test you could simply do a "make malta_defconfig", enable CONFIG_API via menuconfig and build. Without this patch you'll get: $ /opt/gcc-9.2.0-nolibc/mips-linux/bin/mips-linux-readelf -s examples/api/demo | grep __start 64: 80200700 16 FUNC GLOBAL DEFAULT 1 __start But with this patch __start will now an unresolved symbol: $ /opt/gcc-9.2.0-nolibc/mips-linux/bin/mips-linux-readelf -s examples/api/demo | grep __start 19: 00000000 0 NOTYPE GLOBAL DEFAULT UND __start But I'm not sure if the original intention was to use the default linker script or the one provided by U-Boot and if examples/api/ should use the same compiler and linker flags as example/standalone/. Some archs have used a custom linker script. Maybe Wolfgang knows more? -- - Daniel