From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EBE1C433F5 for ; Thu, 19 May 2022 11:40:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E290083D9F; Thu, 19 May 2022 13:40:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dWqAuasZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B9CD684269; Thu, 19 May 2022 13:39:51 +0200 (CEST) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7B02E842A9 for ; Thu, 19 May 2022 13:39:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x634.google.com with SMTP id tk15so9378265ejc.6 for ; Thu, 19 May 2022 04:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=gUD6NmSFToNVBnhFWTu+l6PgiDHh0Qb5q6nHYdv5/mA=; b=dWqAuasZM/bVT5lFeNxzYAfQVlYufEL3NBJlw/w1yonvBycW22qxq7r2HvTRiL12rA kte//Vho1RxAV+Jn3kq+5SchU6q40dxF8SBGmMnPr02SxQ2RS5j7L01MSQlOCEZvC15J QKaTg5hk7Kt7TuETnFdP21sDL4qBaLvisyBw89DlD3czC5RkBrPicN9V02uEjw0CqbNx 1Y0/UaunEuD34NBTZ9ZpSvK4pL/Xrmz+bxGY6asLOcwgesIVzN20O5Pi7YyY/fpw+apq BDwNfTp2rDOD676TdkKofvgG2JXWkFNLRJfzIlCOnt+O3UG+Rk+xb2hHBVQn5Hinxp3M KwNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=gUD6NmSFToNVBnhFWTu+l6PgiDHh0Qb5q6nHYdv5/mA=; b=Nq56TaRO1pOJLaQzyKxGAB9TZkSrkJ636P8eIuCrHgdFb19MVIzgm9SUTk+YAO685D E3VU5Y8pIOhsekzuJ8wMlda0cFie1iRCPHup7rPIrymX8nT/l6Rmz5TBNTc2VDiMVIpx 5xSQOuDu2xCFm7e9rAnKUCMlYPYfMx7l/U6KNDI1J++Txq6CHhS7oB0Nt7w0XqHLVABN X2Z35bZHBChsulzPeApogBzzUAZtdYvc1WsA3XIhIV0qsMAh69HYzkYU1+sruXwj/bd/ ZgpSd0SnQXUQn+y6Wpgv45LYWR2vL/8FV1sUODlZfg6ojtoJZdMdRVhkhM6GABG2Yv0B 8QXg== X-Gm-Message-State: AOAM533Wlmk3RKo9GS65dDBeXHMkOYcr20ZZBtS3g3kDrs90foxdOXdA CjZjgmBQhdZwxjx4zrD1U6M= X-Google-Smtp-Source: ABdhPJywYcqY7PwwEJeY1Cy5hgxBxYNwplaGJZ+SipiP49xRjUw783o/sK+wbZxhmG0nAIb3efhMug== X-Received: by 2002:a17:907:1ca4:b0:6f4:68b8:99d2 with SMTP id nb36-20020a1709071ca400b006f468b899d2mr3939668ejc.616.1652960387093; Thu, 19 May 2022 04:39:47 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id de22-20020a1709069bd600b006fe9ec4ba9esm298247ejc.52.2022.05.19.04.39.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 04:39:46 -0700 (PDT) Message-ID: Date: Thu, 19 May 2022 14:37:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Alper Nebi Yasak Subject: Re: [RFC PATCH v2 6/8] rockchip: Enable binman for ARM64 To: Andrew Abbott Cc: Jagan Teki , Johan Jonker , Simon Glass , Samuel Dionne-Riel , Peter Robinson , Kever Yang , Philipp Tomsich , Andre Przywara , Bharat Gooty , Bin Meng , Fabio Estevam , =?UTF-8?Q?Marek_Beh=c3=ban?= , Michal Simek , Rayagonda Kokatanur , Rick Chen , Sean Anderson , U-Boot Mailing List References: <20220516110712.178958-1-andrew@mirx.dev> <20220516110712.178958-7-andrew@mirx.dev> Content-Language: en-US In-Reply-To: <20220516110712.178958-7-andrew@mirx.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 16/05/2022 14:07, Andrew Abbott wrote: > Binman is now being used to build the final flashable images for > Rockchip devices, thus enabling it for all Rockchip targets here. But > it is not yet being used to generate the FIT image (u-boot.itb), > thus we need to force it to be built. > > Signed-off-by: Andrew Abbott > --- > Question: Will this causes issues with eg. Chromebook gru/bob, which build > u-boot.itb with binman already? They don't build u-boot.itb with binman. I don't think there would be a issue with them, but didn't actually test (will test later as I said). > (no changes since v1) > > Kconfig | 4 ++-- > arch/arm/Kconfig | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Kconfig b/Kconfig > index 797038b037..7226986830 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -414,8 +414,8 @@ config BUILD_TARGET > default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_GEN5 > default "u-boot-spl.kwb" if ARCH_MVEBU && SPL > default "u-boot-elf.srec" if RCAR_GEN3 > - default "u-boot.itb" if !BINMAN && SPL_LOAD_FIT && (ARCH_ROCKCHIP || \ > - ARCH_SUNXI || RISCV || ARCH_ZYNQMP) > + default "u-boot.itb" if ARCH_ROCKCHIP || (!BINMAN && SPL_LOAD_FIT && \ > + (ARCH_SUNXI || RISCV || ARCH_ZYNQMP)) I can't see how this part is necessary, can you give a concrete example? It also makes evb-rk3288, chromebook_jerry, chromebook_speedy, evb-rk3036 fail to build (maybe more?). > default "u-boot.kwb" if ARCH_KIRKWOOD > default "u-boot-with-spl.bin" if ARCH_AT91 && SPL_NAND_SUPPORT > default "u-boot-with-spl.imx" if ARCH_MX6 && SPL > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 0afec5155b..545bf9a8cc 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1967,7 +1967,7 @@ config ARCH_STM32MP > config ARCH_ROCKCHIP > bool "Support Rockchip SoCs" > select BLK > - select BINMAN if SPL_OPTEE || (SPL && !ARM64) > + select BINMAN if SPL > select DM > select DM_GPIO > select DM_I2C