From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/2] spl: fdt: Record load/entry fit-images entries in 64bit format
Date: Mon, 7 Sep 2020 10:29:09 +0200 [thread overview]
Message-ID: <abbb1090-3750-46c2-0fa5-66f15d760b84@xilinx.com> (raw)
In-Reply-To: <CAPnjgZ2u1iXHsSptQZWV-7_KkoArRKKSbBnfvq6vJasNayyMug@mail.gmail.com>
On 07. 09. 20 3:43, Simon Glass wrote:
> Hi Michal,
>
> On Thu, 3 Sep 2020 at 05:03, Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> The commit 9f45aeb93727 ("spl: fit: implement fdt_record_loadable") which
>> introduced fdt_record_loadable() state there spl_fit.c is not 64bit safe.
>> Based on my tests on Xilinx ZynqMP zcu102 platform there shouldn't be a
>> problem to record these addresses in 64bit format.
>> The patch adds support for systems which need to load images above 4GB.
>
> But what about 32-bit systems who read this as a 32-bit number?
> Perhaps we should write 32-bit if !CONFIG_PHYS_64BIT?
The code for reading doesn't really care if value is 32bit or 64bit.
The fit_image_get_entry() and fit_image_get_load() read number of cells
used and based on that read 32 or 64 bit values.
Thanks,
Michal
next prev parent reply other threads:[~2020-09-07 8:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 11:03 [PATCH 0/2] Add support for loading images above 4GB Michal Simek
2020-09-03 11:03 ` [PATCH 1/2] spl: Use standard FIT entries Michal Simek
2020-09-07 1:43 ` Simon Glass
2020-09-07 8:27 ` Michal Simek
2020-09-07 13:57 ` Simon Glass
2020-09-03 11:03 ` [PATCH 2/2] spl: fdt: Record load/entry fit-images entries in 64bit format Michal Simek
2020-09-07 1:43 ` Simon Glass
2020-09-07 8:29 ` Michal Simek [this message]
2020-09-07 13:57 ` Simon Glass
2020-10-05 8:55 ` Michal Simek
2020-09-07 8:55 ` Michal Simek
2020-09-03 11:16 ` [PATCH 0/2] Add support for loading images above 4GB Heinrich Schuchardt
2020-09-03 12:30 ` Michal Simek
2020-09-07 1:43 ` Simon Glass
2020-09-07 9:00 ` Michal Simek
2020-09-07 13:57 ` Simon Glass
2020-10-05 8:56 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abbb1090-3750-46c2-0fa5-66f15d760b84@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox