Re: [PATCH] imx93-u-boot: Describe the CPU clocks in the devicetree

["Sébastien Szymanski" <sebastien.szymanski@armadeus.com>]

Hello Fabio,

On 7/18/24 18:54, Fabio Estevam wrote:
> Currently, there is an error when the i.MX93 CPU frequency is
> read:
> 
> Could not read CPU frequency: -2
> CPU:   NXP i.MX93(52) Rev1.1 A55 at 0 MHz
> 
> Fix it by describing the A55 clock nodes in the devicetree, like done
> on other i.MX SoCs.
> 
> With this change, the CPU frequency error is gone and it can be correctly
> retrieved:
> 
> CPU:   NXP i.MX93(52) Rev1.1 A55 at 1700 MHz
> CPU:   Industrial temperature grade  (-40C to 105C) at 35C
> 
> As the upstream imx93.dtsi does not describe the CPU clocks,
> keep the clock node in imx93-u-boot.dtsi for now.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>   arch/arm/dts/imx93-u-boot.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/dts/imx93-u-boot.dtsi b/arch/arm/dts/imx93-u-boot.dtsi
> index 289aba175843..b2b3d57318fc 100644
> --- a/arch/arm/dts/imx93-u-boot.dtsi
> +++ b/arch/arm/dts/imx93-u-boot.dtsi
> @@ -9,6 +9,14 @@
>   	};
>   };
>   
> +&A55_0 {
> +	clocks = <&clk IMX93_CLK_ARM_PLL>;

Why IMX93_CLK_ARM_PLL and not IMX93_CLK_A55_SEL ?

Best regards,

> +};
> +
> +&A55_1 {
> +	clocks = <&clk IMX93_CLK_ARM_PLL>;
> +};
> +
>   &binman {
>   	u-boot-spl-ddr {
>   		align = <4>;

-- 
Sébastien Szymanski, Armadeus Systems
Software engineer