From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] usb: dwc2: invalidate the dcache before starting the DMA
Date: Mon, 3 Apr 2017 21:33:14 +0200 [thread overview]
Message-ID: <ac66bfef-e84e-ebba-8002-4e88414dee10@denx.de> (raw)
In-Reply-To: <7851308.6iHcp38Qv5@sbruens-linux>
On 04/03/2017 04:43 PM, Brüns, Stefan wrote:
> On Samstag, 1. April 2017 08:51:39 CEST Eddie Cai wrote:
>> We should invalidate the dcache before starting the DMA. In case there are
>> any dirty lines from the DMA buffer in the cache, subsequent cache-line
>> replacements may corrupt the buffer in memory while the DMA is still going
>> on. Cache-line replacement can happen if the CPU tries to bring some other
>> memory locations into the cache while the DMA is going on.
>>
>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>
> Can you please run the patch through checkpatch, I can at least spot some
> missing whitespace.
>
> You can add my
>
> Reviewed-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
>
> to your v2.
Works for me too, looking forward to v2.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-04-03 19:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 6:51 [U-Boot] usb: dwc2: invalidate the dcache before starting the DMA Eddie Cai
2017-04-03 14:43 ` Brüns, Stefan
2017-04-03 19:33 ` Marek Vasut [this message]
2017-04-05 1:26 ` Kever Yang
2017-04-05 2:21 ` Simon Glass
2017-04-05 9:35 ` Marek Vasut
2017-04-05 10:08 ` Simon Glass
2017-04-05 10:21 ` Marek Vasut
2017-04-05 15:03 ` Simon Glass
2017-04-05 21:34 ` Marek Vasut
2017-04-06 1:24 ` Simon Glass
2017-04-06 1:32 ` Marek Vasut
2017-04-06 2:40 ` Simon Glass
2017-04-06 10:22 ` Marek Vasut
2017-04-06 14:06 ` Simon Glass
2017-04-06 15:33 ` Marek Vasut
2017-04-06 15:57 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac66bfef-e84e-ebba-8002-4e88414dee10@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox