From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 3 Apr 2017 21:33:14 +0200 Subject: [U-Boot] usb: dwc2: invalidate the dcache before starting the DMA In-Reply-To: <7851308.6iHcp38Qv5@sbruens-linux> References: <20170401065139.12084-1-eddie.cai.linux@gmail.com> <7851308.6iHcp38Qv5@sbruens-linux> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On 04/03/2017 04:43 PM, Brüns, Stefan wrote: > On Samstag, 1. April 2017 08:51:39 CEST Eddie Cai wrote: >> We should invalidate the dcache before starting the DMA. In case there are >> any dirty lines from the DMA buffer in the cache, subsequent cache-line >> replacements may corrupt the buffer in memory while the DMA is still going >> on. Cache-line replacement can happen if the CPU tries to bring some other >> memory locations into the cache while the DMA is going on. >> >> Signed-off-by: Eddie Cai > > Can you please run the patch through checkpatch, I can at least spot some > missing whitespace. > > You can add my > > Reviewed-by: Stefan Brüns > > to your v2. Works for me too, looking forward to v2. -- Best regards, Marek Vasut