From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCC6CC433EF for ; Mon, 20 Dec 2021 07:03:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3CD21830F5; Mon, 20 Dec 2021 08:03:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1639983805; bh=AIL8jngyed9y53Th66HcVbn+ZpSBgrWtZ1m0jAQpx6k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=NjtC62CnkIvwDtczUb6zlqnP3Nc+1bJ+mfEXZ4hxUmN9djVre4M9BHsAufiZ5UPJy YXnymZiWYYi3XlMrbj7A//EoYGuMmDkjAf8/yKF6/SgZegonycwu5giPadFMyZrfnI hi0UZi29SvuFuz/iKE+Xc6KGJoxF0Y9EIZFxZTZczD7zq6xb5SAsSNH+E4vEfDficV FnasSpu3NWWKf6SFGksIxj9dC29QEv99ZFXYBtsPwWUcSSEu6jd1A8F/D824Amswn9 KpB1/yY9gVQLRfaUeY1FSPx2SNd7sUQ51bR+JCjVSc5Ig1QwSSL9hsZtR29Lt1QML/ +6Cs+HQLOA4AQ== Received: from [192.168.1.107] (82-131-202-6.pool.digikabel.hu [82.131.202.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hs@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 62AFF8309F; Mon, 20 Dec 2021 08:03:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1639983802; bh=AIL8jngyed9y53Th66HcVbn+ZpSBgrWtZ1m0jAQpx6k=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=wuYTJn0kJoMjcE0+GyZPbJiELxaf2mUsp8iskLtULK09iV/RZxeKoG4aq7GsmIzFh hD9ONtnlzw9tOwdlhW/L/6ViMTWNGG/olvzTWT8icwlCLC7NWljZsSDUDAzW+376Zm iy9PhwKXR5NV4blduZwihPx6PM0ZwYdW08I9idtjlCI6kHuqJa4+k7TRINss307unE om/ep4ybmBrqdMhSAkXvaytErpJXH4jvtk+caDQhlEd5PTS+uDKpEmSDXHlBLxmovU lFIv8AV6se6FNDSAwJUsJg9fziUjJuEYnYho3Qqyo6U2+B7a0DIDaUlmLa/GmBX935 O1fpsW116ogEg== Subject: Re: [PATCH] i2c: mvtwsi: Swab the register address if its size is > 1 To: =?UTF-8?Q?Marek_Beh=c3=ban?= , Stefan Roese Cc: u-boot@lists.denx.de, Samuel Holland , Baruch Siach , =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20211118081841.861158-1-sr@denx.de> <3542e49a-aedf-406c-8927-a47fff172f92@denx.de> <20211218234150.7d21f2aa@thinkpad> From: Heiko Schocher Message-ID: Date: Mon, 20 Dec 2021 08:03:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20211218234150.7d21f2aa@thinkpad> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hs@denx.de Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hello Marek, On 18.12.21 23:41, Marek Behún wrote: > On Sat, 18 Dec 2021 14:42:51 +0100 > Stefan Roese wrote: > >> Hi Heiko, >> >> On 11/18/21 09:18, Stefan Roese wrote: >>> Testing on Armada XP with an EEPROM using register address with size >>> of 2 has shown, that the register address bytes are sent to the I2C >>> EEPROM in the incorrect order. This patch swabs the address bytes so >>> that the correct address is transferred to the I2C device. >>> >>> BTW: This worked without any issues before migrating Armada XP to >>> DM I2C. >>> >>> Signed-off-by: Stefan Roese >>> Cc: Heiko Schocher >>> Cc: Samuel Holland >>> Cc: Baruch Siach >>> Cc: Pali Rohár >>> Cc: Marek Behún >>> --- >>> It would be good if other users of this I2C driver could test this change >>> with e.g. I2C EEPROM devices using 2 bytes (or more) for addressing. >> >> Could you and other please take a look at this? Would be great, if this >> could be pulled in the next merge window. > > Tested-by: Marek Behún > Thanks for testing. Just triggered azure build now, if all works fine, I send a pull request to Tom. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de