Re: [PATCH v4 0/2] qcom: EFI PSCI runtime reset handling and config update

[Sumit Garg <sumit.garg@kernel.org>]

On Tue, Mar 24, 2026 at 11:29:11PM +0530, Aswin Murugan wrote:
> From: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
> 
> With CONFIG_PSCI_RESET enabled, EFI runtime resets always use PSCI, but since
> it cannot pass the arguments needed for special reboot modes, requests like
> bootloader or EDL fall back to a normal reboot.
> 
> This version updates the earlier series that introduced configuration control
> over EFI PSCI-based runtime reset handling.
> 
> During review [1], it was pointed out that modifying only the Kconfig option
> was incomplete, as the EFI runtime configuration table in
> lib/efi_loader/efi_runtime.c also needs to be updated to reflect whether
> runtime reset support is enabled.
> 
> Additionally, the reviewer suggested that instead of introducing a new
> EFI_PSCI_RESET_RUNTIME option, we should reuse the existing
> EFI_HAVE_RUNTIME_RESET knob, making it user-configurable so platforms can
> opt out when the kernel must retain full control of specialized reboot
> modes.
> 
> This version implements that feedback:
> 
> 1. EFI_HAVE_RUNTIME_RESET is now a proper Kconfig configurable option
>    This allows individual platforms, such as Qualcomm boards, to 
>    explicitly disable U-Boot’s EFI runtime reset callbacks when required.
> 
> 2. The Qualcomm defconfig disables EFI_HAVE_RUNTIME_RESET so that the
>    kernel can manage advanced reboot flows (EDL, bootloader entry, etc.)
>    without U-Boot overriding those reset modes through EFI runtime
>    services.
> 
> 3. The EFI runtime table is updated accordingly to conditionally
>    advertise reset support only when EFI_HAVE_RUNTIME_RESET is enabled.
> 
> These changes maintain existing default behavior for platforms that rely
> on U-Boot’s EFI reset services, while enabling platforms with more
> complex reboot semantics to opt out cleanly.
> 
> [1] https://lore.kernel.org/all/CAC_iWjKZXsE86J_wJ=JTE0TGL=MqGm8YRYsq4BrkU2ba3me6OQ@mail.gmail.com/
> 
> Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
> ---
> Changes in v4:
> - Made EFI_HAVE_RUNTIME_RESET user configurable & used it to disable U-Boot’s EFI runtime reset
>   for qualcomm platforms
> - Link to v3: https://lore.kernel.org/all/20260213110527.1254098-1-aswin.murugan@oss.qualcomm.com/

For the series:

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> Changes in v3:
> - Updated the commit message
> - Changed 'CONFIG_EFI_PSCI_RESET_RUNTIME=n' to '# CONFIG_EFI_PSCI_RESET_RUNTIME is not set'
> - Link to v2: https://lore.kernel.org/all/20260114111624.2321852-1-aswin.murugan@oss.qualcomm.com/
> 
> Changes in v2:
> - As per review comments made default y for EFI_PSCI_RESET_RUNTIME config
> - Disabled the EFI_PSCI_RESET_RUNTIME config for qualcomm platforms
> - Link to v1: https://lore.kernel.org/all/20260108105146.1285450-1-aswin.murugan@oss.qualcomm.com/
> ---
> Aswin Murugan (2):
>   efi_loader: make EFI_HAVE_RUNTIME_RESET a user-selectable option
>   qcom_defconfig: Disable EFI_HAVE_RUNTIME_RESET in qcom_defconfig
> 
>  configs/qcom_defconfig | 1 +
>  lib/efi_loader/Kconfig | 3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.34.1
>