Re: [PATCH v2 3/7] drivers: phy: qcom: Add QMP USB3-DP Combo PHY driver

[Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>]

On 11/25/2025 1:21 AM, Tom Rini wrote:
> On Mon, Nov 24, 2025 at 09:24:59PM +0530, Balaji Selvanathan wrote:
>
>> Add support for the Qualcomm QMP USB3-DP Combo PHY found on
>> SC7280 and QCM6490 platforms. This driver currently implements
>> USB3 super-speed functionality of the combo PHY.
>>
>> The QMP Combo PHY is a dual-mode PHY
>> that can operate in either USB3 mode or DisplayPort mode. This
>> initial implementation focuses on USB3 mode to enable Super-Speed
>> USB support.
>>
>> This is a port of the upstream Linux files to U-Boot:
>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/qualcomm/phy-qcom-qmp-combo.c?id=3d25d46a255a83f94d7d4d4216f38aafc8e116b0
>>
>> Enabled and tested the driver on Qualcomm RB3 Gen2 (QCS6490) board.
>>
>> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> [snip]
>> diff --git a/drivers/phy/qcom/Kconfig b/drivers/phy/qcom/Kconfig
>> index 0dd69f7ffd0..49f830abf01 100644
>> --- a/drivers/phy/qcom/Kconfig
>> +++ b/drivers/phy/qcom/Kconfig
>> @@ -12,6 +12,14 @@ config PHY_QCOM_IPQ4019_USB
>>   	help
>>   	  Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s.
>>   
>> +config PHY_QCOM_QMP_COMBO
>> +	bool "Qualcomm QMP USB3-DP Combo PHY driver"
>> +	depends on PHY && ARCH_SNAPDRAGON
>> +	help
>> +	  Enable this to support the USB3-DP Combo QMP PHY on various Qualcomm
>> +	  chipsets. This driver supports the USB3 PHY functionality of the combo
>> +	  PHY (USB3 + DisplayPort). Currently only USB3 mode is supported.
>> +
>>   config PHY_QCOM_QMP_PCIE
>>   	tristate "Qualcomm QMP PCIe PHY driver"
> Can you please do a follow-up to fix this tristate (and any other in
> qualcomm specific Kconfig files) ? Thanks!

Sure Tom, will create a seperate patch to fix the tristates.

Thanks,

Balaji

>