[PATCH] clk: versaclock: Fix incorrect error check in versaclock_probe()

[PATCH] clk: versaclock: Fix incorrect error check in versaclock_probe()

[Kuan-Wei Chiu]

The error check during the registration of FODs is incorrect. The code
currently checks IS_ERR(pll_name) immediately after assigning
fod_name[n].

Since pll_name is checked in a previous block, this condition will
always be false, causing any allocation failure in
versaclock_get_name() for fod_name to be ignored. This could lead
to usage of an invalid pointer.

Fix the condition to check fod_name[n] instead.

Fixes: dcf2cee77f2d ("clk: clk_versaclock: Add support for versaclock driver")
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
 drivers/clk/clk_versaclock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk_versaclock.c b/drivers/clk/clk_versaclock.c
index 19a787eaf0c..1dbde75f180 100644
--- a/drivers/clk/clk_versaclock.c
+++ b/drivers/clk/clk_versaclock.c
@@ -945,7 +945,7 @@ int versaclock_probe(struct udevice *dev)
 	/* Register FODs */
 	for (n = 0; n < vc5->chip_info->clk_fod_cnt; n++) {
 		fod_name[n] = versaclock_get_name(dev->name, "fod", n);
-		if (IS_ERR(pll_name)) {
+		if (IS_ERR(fod_name[n])) {
 			ret = PTR_ERR(fod_name[n]);
 			goto free_fod;
 		}
-- 
2.52.0.239.gd5f0c6e74e-goog

Re: [PATCH] clk: versaclock: Fix incorrect error check in versaclock_probe()

[Sean Anderson]

On 12/12/25 13:06, Kuan-Wei Chiu wrote:
> The error check during the registration of FODs is incorrect. The code
> currently checks IS_ERR(pll_name) immediately after assigning
> fod_name[n].
>
> Since pll_name is checked in a previous block, this condition will
> always be false, causing any allocation failure in
> versaclock_get_name() for fod_name to be ignored. This could lead
> to usage of an invalid pointer.
>
> Fix the condition to check fod_name[n] instead.
>
> Fixes: dcf2cee77f2d ("clk: clk_versaclock: Add support for versaclock driver")
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
>  drivers/clk/clk_versaclock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk_versaclock.c b/drivers/clk/clk_versaclock.c
> index 19a787eaf0c..1dbde75f180 100644
> --- a/drivers/clk/clk_versaclock.c
> +++ b/drivers/clk/clk_versaclock.c
> @@ -945,7 +945,7 @@ int versaclock_probe(struct udevice *dev)
>       /* Register FODs */
>       for (n = 0; n < vc5->chip_info->clk_fod_cnt; n++) {
>               fod_name[n] = versaclock_get_name(dev->name, "fod", n);
> -             if (IS_ERR(pll_name)) {
> +             if (IS_ERR(fod_name[n])) {
>                       ret = PTR_ERR(fod_name[n]);
>                       goto free_fod;
>               }

Reviewed-by: Sean Anderson <sean.anderson@seco.com>

[CES 2026, SECO]<https://exhibitors.ces.tech/8_0/exhibitor/exhibitor-details.cfm?exhid=001Pp000010EbaOIAS>

Re: [PATCH] clk: versaclock: Fix incorrect error check in versaclock_probe()

[Kuan-Wei Chiu]

On Fri, Dec 12, 2025 at 01:40:39PM -0500, Sean Anderson wrote:
> On 12/12/25 13:06, Kuan-Wei Chiu wrote:
> > The error check during the registration of FODs is incorrect. The code
> > currently checks IS_ERR(pll_name) immediately after assigning
> > fod_name[n].
> >
> > Since pll_name is checked in a previous block, this condition will
> > always be false, causing any allocation failure in
> > versaclock_get_name() for fod_name to be ignored. This could lead
> > to usage of an invalid pointer.
> >
> > Fix the condition to check fod_name[n] instead.
> >
> > Fixes: dcf2cee77f2d ("clk: clk_versaclock: Add support for versaclock driver")
> > Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> > ---
> >  drivers/clk/clk_versaclock.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk_versaclock.c b/drivers/clk/clk_versaclock.c
> > index 19a787eaf0c..1dbde75f180 100644
> > --- a/drivers/clk/clk_versaclock.c
> > +++ b/drivers/clk/clk_versaclock.c
> > @@ -945,7 +945,7 @@ int versaclock_probe(struct udevice *dev)
> >       /* Register FODs */
> >       for (n = 0; n < vc5->chip_info->clk_fod_cnt; n++) {
> >               fod_name[n] = versaclock_get_name(dev->name, "fod", n);
> > -             if (IS_ERR(pll_name)) {
> > +             if (IS_ERR(fod_name[n])) {
> >                       ret = PTR_ERR(fod_name[n]);
> >                       goto free_fod;
> >               }
> 
> Reviewed-by: Sean Anderson <sean.anderson@seco.com>
> 
Thanks for the review!

Just a gentle ping on this patch from last December.
It looks like it might have slipped through the cracks.

Regards,
Kuan-Wei