From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB214F8E48C for ; Thu, 16 Apr 2026 23:26:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 51B3F83FC0; Fri, 17 Apr 2026 01:26:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A520F8407E; Fri, 17 Apr 2026 01:26:13 +0200 (CEST) Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [IPv6:2a07:2ec0:3002::65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 47B2D83EEF for ; Fri, 17 Apr 2026 01:26:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel@makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1wDW5n-000000006tD-2pI3; Thu, 16 Apr 2026 23:25:51 +0000 Date: Fri, 17 Apr 2026 00:25:47 +0100 From: Daniel Golle To: Simon Glass Cc: Tom Rini , Quentin Schulz , Kory Maincent , Mattijs Korpershoek , Peng Fan , Heinrich Schuchardt , Martin Schwan , Anshul Dalal , Ilias Apalodimas , Sughosh Ganu , Aristo Chen , Ludwig Nussel , Benjamin ROBIN , Marek Vasut , James Hilliard , Wolfgang Wallner , Kunihiko Hayashi , David Lechner , Neil Armstrong , Mayuresh Chitale , Jonas Karlman , Shiji Yang , Rasmus Villemoes , Francois Berder , u-boot@lists.denx.de Subject: Re: [PATCH v2 6/7] test: boot: add runtime unit test for fit_verity_build_cmdline() Message-ID: References: <97e38b81f2e8f54ec819940d360849e4cf61b875.1776302806.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, Apr 17, 2026 at 07:36:37AM +1200, Simon Glass wrote: > Hi Daniel, > > On 2026-04-16T01:46:15, Daniel Golle wrote: > > test: boot: add runtime unit test for fit_verity_build_cmdline() > > > > Add test/boot/fit_verity.c with four tests that construct FIT blobs > > in memory and exercise fit_verity_build_cmdline(). > > > > Signed-off-by: Daniel Golle > > > > test/boot/Makefile | 1 + > > test/boot/fit_verity.c | 302 +++++++++++++++++++++++++++++++++++++++++++++++++ > > test/cmd_ut.c | 2 + > > 3 files changed, 305 insertions(+) > > > diff --git a/test/boot/fit_verity.c b/test/boot/fit_verity.c > > @@ -0,0 +1,302 @@ > > + ret = fdt_setprop_string(buf, verity_node, "algo", "sha256"); > > + val = cpu_to_fdt32(4096); > > + ret = fdt_setprop(buf, verity_node, "data-block-size", > > Please can you use the FIT_VERITY_*_PROP constants from > include/image.h instead of literal strings? See test/image/spl_load.c > for an example. Sure, I'll change that. I was deliberately not doing it so the test code is as self-contained as possible.