public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 05/18] usb: dwc3: switch to peripheral mode when exiting
Date: Mon, 29 Apr 2019 11:56:56 +0200	[thread overview]
Message-ID: <af2743e6-66ed-33df-e723-94515d925ace@gmail.com> (raw)
In-Reply-To: <20190405125554.18070-6-jjhiblot@ti.com>

On 4/5/19 2:55 PM, Jean-Jacques Hiblot wrote:
> This allow the phy to enter idle and then suspend.
> the K2 platforms require the PHY to be suspended before the USB domain
> clock can be turned off.
> 
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
> 
>  drivers/usb/dwc3/core.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 56e2a046bf..ae01490306 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -581,6 +581,12 @@ static int dwc3_core_init_mode(struct dwc3 *dwc)
>  	return 0;
>  }
>  
> +static void dwc3_gadget_run(struct dwc3 *dwc)
> +{
> +	dwc3_writel(dwc->regs, DWC3_DCTL, DWC3_DCTL_RUN_STOP);
> +	mdelay(100);

That's long, is this really needed ?

> +}
> +
>  static void dwc3_core_exit_mode(struct dwc3 *dwc)
>  {
>  	switch (dwc->dr_mode) {
> @@ -598,6 +604,13 @@ static void dwc3_core_exit_mode(struct dwc3 *dwc)
>  		/* do nothing */
>  		break;
>  	}
> +
> +	/*
> +	 * switch back to peripheral mode
> +	 * This enables the phy to enter idle and then, if enabled, suspend.
> +	 */
> +	dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_DEVICE);
> +	dwc3_gadget_run(dwc);
>  }
>  
>  #define DWC3_ALIGN_MASK		(16 - 1)
> 


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2019-04-29  9:56 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 12:55 [U-Boot] [PATCH v1 00/18] Improvement for the DWC3 USB generic driver and fixes for the K2 platforms Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 01/18] usb: dwc3-generic: remove dm_scan_fdt_dev() from the remove() callback Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 02/18] usb: host: remove the xhci-zynqmp driver Jean-Jacques Hiblot
2019-04-29  9:55   ` Marek Vasut
2019-04-29 15:16     ` Michal Simek
2019-04-05 12:55 ` [U-Boot] [PATCH v1 03/18] dm: Add a No-op uclass Jean-Jacques Hiblot
2019-04-29  9:56   ` Marek Vasut
2019-05-03  9:30     ` Jean-Jacques Hiblot
2019-05-03  9:57       ` Marek Vasut
2019-05-07  3:52   ` Simon Glass
2019-05-13 10:28     ` Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 04/18] usb: dwc3: Use UCLASS_NOP instead of UCLASS_MISC for the DWC3 generic glue Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 05/18] usb: dwc3: switch to peripheral mode when exiting Jean-Jacques Hiblot
2019-04-29  9:56   ` Marek Vasut [this message]
2019-05-03  9:26     ` Jean-Jacques Hiblot
2019-05-03  9:57       ` Marek Vasut
2019-04-05 12:55 ` [U-Boot] [PATCH v1 06/18] usb: xhci: move xhci.h to include usb Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 07/18] usb: dwc3: always use the inlined version of dwc3_host_init/dwc3_host_exit Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 08/18] usb: dwc3-generic: use platdata Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 09/18] usb: dwc3-generic: factorize code Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 10/18] usb: dwc3-generic: add a new host driver that uses the dwc3 core Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 11/18] usb: dwc3-generic: if no max speed is specified in DT, assume super speed Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 12/18] usb: dwc3: Add dwc3_of_parse() to get quirks information from DT Jean-Jacques Hiblot
2019-04-29  9:58   ` Marek Vasut
2019-05-03  9:38     ` Jean-Jacques Hiblot
2019-05-03  9:58       ` Marek Vasut
2019-04-05 12:55 ` [U-Boot] [PATCH v1 13/18] usb: dwc3: Kconfig: get rid of obsolete mode selection Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 14/18] ARM: keystone: increase PSC timeout Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 15/18] ARM: keystone: Do not enable the USB power domains at the board level Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 16/18] phy: keystone-usb: handle the transition of the USB power domain Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 17/18] configs: k2g_evm_defconfig: disable XHCI_DWC3 and enable KEYSTONE_USB_PHY Jean-Jacques Hiblot
2019-04-05 12:55 ` [U-Boot] [PATCH v1 18/18] ARM: DTS: keystone: complete the description of the USB PHY devices Jean-Jacques Hiblot
2019-04-29  9:09 ` [U-Boot] [PATCH v1 00/18] Improvement for the DWC3 USB generic driver and fixes for the K2 platforms Jean-Jacques Hiblot
2019-04-29  9:52   ` Marek Vasut
2019-04-29  9:54     ` Marek Vasut
2019-05-03  9:39     ` Jean-Jacques Hiblot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af2743e6-66ed-33df-e723-94515d925ace@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox