From: Sumit Garg <sumit.garg@kernel.org>
To: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io,
"Tom Rini" <trini@konsulko.com>,
"Quentin Schulz" <quentin.schulz@cherry.de>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Javier Tia" <javier.tia@linaro.org>,
"Varadarajan Narayanan" <quic_varada@quicinc.com>,
"Rasmus Villemoes" <ravi@prevas.dk>,
"Mikhail Kshevetskiy" <mikhail.kshevetskiy@iopsys.eu>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"João Marcos Costa" <joaomarcos.costa@bootlin.com>,
"Tien Fong Chee" <tien.fong.chee@altera.com>,
"Richard Genoud" <richard.genoud@bootlin.com>,
"Jan Kiszka" <jan.kiszka@siemens.com>,
"David Lechner" <dlechner@baylibre.com>,
"Casey Connolly" <casey.connolly@linaro.org>,
"Simon Glass" <simon.glass@canonical.com>,
"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Michael Walle" <mwalle@kernel.org>,
"Sumit Garg" <sumit.garg@oss.qualcomm.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Aswin Murugan" <aswin.murugan@oss.qualcomm.com>,
"Varadarajan Narayanan" <varadarajan.narayanan@oss.qualcomm.com>,
"Simon Glass" <sjg@chromium.org>,
"Mattijs Korpershoek" <mkorpershoek@kernel.org>,
"Jerome Forissier" <jerome.forissier@arm.com>
Subject: Re: [PATCH v3 0/5] Add partition type GUID support for environment
Date: Fri, 1 May 2026 13:26:42 +0530 [thread overview]
Message-ID: <afRcurpPhg4BAgP0@sumit-xelite> (raw)
In-Reply-To: <cd81616a-0d04-4a3e-93a2-b8ab35093ea7@oss.qualcomm.com>
On Mon, Apr 27, 2026 at 10:19:30PM +0530, Balaji Selvanathan wrote:
>
> On 4/20/2026 7:07 PM, Sumit Garg wrote:
> > On Sun, Apr 19, 2026 at 03:54:02PM +0530, Balaji Selvanathan wrote:
> > > This series adds support for locating partitions using GPT partition
> > > type GUID instead of unique partition UUID. This enables the saveenv
> > > command to work with partitions identified by their type rather than
> > > unique identifiers, providing flexibility for systems where partition
> > > UUIDs may vary across devices but types remain constant.
> > Why don't we rather rely on partition name/label instead? That can be
> > common across platforms too. I would rather prefer a config fragment for
> > eg. UFS based environment or eMMC based environment and so on.
> >
> > -Sumit
>
> Hi Sumit,
>
> Using type GUIDs as they offer following advantages: they are standardized
> across vendors (e.g., ChromeOS kernel GUID, Linux filesystem GUID) unlike
> arbitrary partition names that vary by OEM or firmware version, they are
> immutable and set at partition creation, making them more robust than
> easily-modified partition names.
>
That's fair, let's at least document the partition name used for
environment in the defconfig such that it's easier for users to know
that.
-Sumit
>
> >
> > > Patch 1 adds part_get_info_by_type_guid() function support
> > > Patch 2 adds scsi_get_blk_by_type_guid() function support
> > > Patch 3 adds support for partition type GUID based environment
> > > Patch 4 enables partition type GUID configs for QCM6490 and QCS615
> > > Patch 5 adds unit test for the partition type GUID lookup functionality
> > >
> > > Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> > > ---
> > > Changes in v3:
> > > - Addressed minor corrections in Patch 1 in part_get_info_by_type_guid function
> > > - Refactor env_scsi_get_part and env_scsi_load functions based
> > > on the choice configs in Patch 3
> > > - Add unit test for the partition type GUID lookup functionality in Patch 5
> > > - Link to v2: https://lore.kernel.org/u-boot/20260109070912.4106466-1-balaji.selvanathan@oss.qualcomm.com/
> > >
> > > Changes in v2:
> > > - Compute blk_find_max_devnum(UCLASS_SCSI) only once in scsi_get_blk_by_type_guid()
> > > - Introduce a Kconfig choice config to select between UUID-based
> > > and type GUID-based partition lookup methods.
> > > - Enable above new config in qcom_qcs615_defconfig and qcm6490_defconfig
> > > - Link to v1: https://lore.kernel.org/u-boot/20260108064947.3237361-1-balaji.selvanathan@oss.qualcomm.com/
> > >
> > > ---
> > > Balaji Selvanathan (5):
> > > disk: Add partition lookup by type GUID functionality
> > > scsi: Add partition lookup by type GUID for SCSI devices
> > > env: scsi: Add support for partition type GUID based environment
> > > configs: Enable partition type GUID for QCM6490 and QCS615 boards
> > > test: dm: Add partition type GUID lookup test
> > >
> > > configs/qcm6490_defconfig | 5 +++++
> > > configs/qcom_qcs615_defconfig | 5 +++++
> > > disk/part.c | 37 +++++++++++++++++++++++++++++++
> > > drivers/scsi/scsi-uclass.c | 28 ++++++++++++++++++++++--
> > > env/Kconfig | 51 ++++++++++++++++++++++++++++++++++++-------
> > > env/scsi.c | 45 +++++++++++++++++++++++---------------
> > > include/part.h | 21 ++++++++++++++++++
> > > include/scsi.h | 11 ++++++++++
> > > test/dm/part.c | 48 ++++++++++++++++++++++++++++++++++++++++
> > > 9 files changed, 223 insertions(+), 28 deletions(-)
> > > ---
> > > base-commit: e3405917a1806971d9e72a94186b299f05581e1a
> > > change-id: 20260419-type-c6a48a1c273d
> > >
> > > Best regards,
> > > --
> > > Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> > >
prev parent reply other threads:[~2026-05-01 7:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 10:24 [PATCH v3 0/5] Add partition type GUID support for environment Balaji Selvanathan
2026-04-19 10:24 ` [PATCH v3 1/5] disk: Add partition lookup by type GUID functionality Balaji Selvanathan
2026-04-20 1:17 ` Simon Glass
2026-04-19 10:24 ` [PATCH v3 2/5] scsi: Add partition lookup by type GUID for SCSI devices Balaji Selvanathan
2026-04-20 22:38 ` David Lechner
2026-04-19 10:24 ` [PATCH v3 3/5] env: scsi: Add support for partition type GUID based environment Balaji Selvanathan
2026-04-20 1:18 ` Simon Glass
2026-04-20 22:35 ` David Lechner
2026-04-19 10:24 ` [PATCH v3 4/5] configs: Enable partition type GUID for QCM6490 and QCS615 boards Balaji Selvanathan
2026-04-20 1:18 ` Simon Glass
2026-04-19 10:24 ` [PATCH v3 5/5] test: dm: Add partition type GUID lookup test Balaji Selvanathan
2026-04-20 1:18 ` Simon Glass
2026-04-20 13:37 ` [PATCH v3 0/5] Add partition type GUID support for environment Sumit Garg
2026-04-27 16:49 ` Balaji Selvanathan
2026-05-01 7:56 ` Sumit Garg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afRcurpPhg4BAgP0@sumit-xelite \
--to=sumit.garg@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=aswin.murugan@oss.qualcomm.com \
--cc=balaji.selvanathan@oss.qualcomm.com \
--cc=casey.connolly@linaro.org \
--cc=dlechner@baylibre.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=javier.tia@linaro.org \
--cc=javierm@redhat.com \
--cc=jerome.forissier@arm.com \
--cc=joaomarcos.costa@bootlin.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=miquel.raynal@bootlin.com \
--cc=mkorpershoek@kernel.org \
--cc=mwalle@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quentin.schulz@cherry.de \
--cc=quic_varada@quicinc.com \
--cc=ravi@prevas.dk \
--cc=richard.genoud@bootlin.com \
--cc=simon.glass@canonical.com \
--cc=sjg@chromium.org \
--cc=sumit.garg@oss.qualcomm.com \
--cc=tien.fong.chee@altera.com \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox