From: Lukas Timmermann <linux@timmermann.space>
To: Lukas Timmermann <uboot@timmermann.space>, u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Neil Armstrong <neil.armstrong@linaro.org>, Yao Zi <me@ziyao.cc>,
Kory Maincent <kory.maincent@bootlin.com>,
Peng Fan <peng.fan@nxp.com>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Stefan Roese <stefan.roese@mailbox.org>,
Philip Molloy <philip.molloy@analog.com>,
Jerome Forissier <jerome.forissier@arm.com>,
Kaustabh Chakraborty <kauschluss@disroot.org>,
Henrik Grimler <henrik@grimler.se>,
Minkyu Kang <mk7.kang@samsung.com>
Subject: Re: [PATCH RFC v3 2/2] gpio: s5p: Disable when using upstream DTS
Date: Wed, 6 May 2026 01:28:31 +0200 [thread overview]
Message-ID: <afp807qAJ0IV9EKP@archstation> (raw)
In-Reply-To: <20260506-pinctrl-exyno5250-v3-2-11649fe82210@timmermann.space>
On Wed, May 06, 2026 at 01:13:30AM +0200, Lukas Timmermann wrote:
> Prevent the older s5p_gpio driver from probing when using upstream DTs
> because of incompatibilities. pinctrl_exynos5250 driver should be used
> instead which binds the s5p_gpio for gpio features but replaces pinctrl.
>
> Signed-off-by: Lukas Timmermann <uboot@timmermann.space>
> ---
> drivers/gpio/s5p_gpio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/s5p_gpio.c b/drivers/gpio/s5p_gpio.c
> index c072f146514..f32c5f7ae1a 100644
> --- a/drivers/gpio/s5p_gpio.c
> +++ b/drivers/gpio/s5p_gpio.c
> @@ -353,7 +353,9 @@ static const struct udevice_id exynos_gpio_ids[] = {
> { .compatible = "samsung,s5pc110-pinctrl" },
> { .compatible = "samsung,exynos4210-pinctrl" },
> { .compatible = "samsung,exynos4x12-pinctrl" },
> +#if IS_ENABLED(CONFIG_OF_UPSTREAM)
I just noticed, that this if should be inverted. Will be fixed in the
next patch. Sorry for the noise.
> { .compatible = "samsung,exynos5250-pinctrl" },
> +#endif
> { .compatible = "samsung,exynos5420-pinctrl" },
> { .compatible = "samsung,exynos78x0-gpio" },
> { }
>
> --
> 2.54.0
>
Best regards
Lukas Timmermann
next prev parent reply other threads:[~2026-05-06 4:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 23:13 [PATCH RFC v3 0/2] Modern pinctrl for Exynos5250 devices Lukas Timmermann
2026-05-05 23:13 ` [PATCH RFC v3 1/2] pinctrl: exynos: Add exynos5250 driver Lukas Timmermann
2026-05-05 23:13 ` [PATCH RFC v3 2/2] gpio: s5p: Disable when using upstream DTS Lukas Timmermann
2026-05-05 23:28 ` Lukas Timmermann [this message]
2026-05-06 13:14 ` [PATCH RFC v3 0/2] Modern pinctrl for Exynos5250 devices Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afp807qAJ0IV9EKP@archstation \
--to=linux@timmermann.space \
--cc=henrik@grimler.se \
--cc=jerome.forissier@arm.com \
--cc=kauschluss@disroot.org \
--cc=kory.maincent@bootlin.com \
--cc=me@ziyao.cc \
--cc=mk7.kang@samsung.com \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=philip.molloy@analog.com \
--cc=quentin.schulz@cherry.de \
--cc=raymond.mao@riscstar.com \
--cc=sjg@chromium.org \
--cc=stefan.roese@mailbox.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot@timmermann.space \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox