U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Valla <francesco@valla.it>
To: Quentin Schulz <quentin.schulz@cherry.de>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
	 Marek Vasut <marek.vasut+renesas@mailbox.org>,
	James Hilliard <james.hilliard1@gmail.com>,
	 Julien Stephan <jstephan@baylibre.com>,
	Frank Wunderlich <frank-w@public-files.de>,
	 Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	 Anshul Dalal <anshuld@ti.com>,
	Leo Yu-Chi Liang <ycliang@andestech.com>,
	 Andrew Goodbody <andrew.goodbody@linaro.org>,
	Ronald Wahl <ronald.wahl@legrand.com>,
	 Simon Glass <sjg@chromium.org>, Dhruva Gole <d-gole@ti.com>,
	 Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	Rasmus Villemoes <ravi@prevas.dk>,
	 Michael Walle <mwalle@kernel.org>,
	Marek Vasut <marek.vasut@mailbox.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Genoud <richard.genoud@bootlin.com>,
	 Wolfgang Wallner <wolfgang.wallner@at.abb.com>,
	David Lechner <dlechner@baylibre.com>
Subject: Re: [PATCH 3/5] boot: fit: enable FIT image post-processing in SPL
Date: Thu, 7 May 2026 22:18:32 +0200	[thread overview]
Message-ID: <afzzakAEtOauxSEw@bywater> (raw)
In-Reply-To: <bcef111f-56a8-4935-b234-0e9558cf13e6@cherry.de>

Hi Quentin

On Thu, May 07, 2026 at 06:17:34PM +0200, Quentin Schulz wrote:
> Hi Francesco,
> 
> On 4/28/26 10:24 PM, Francesco Valla wrote:
> > Since CONFIG_SPL_FIT_IMAGE_POST_PROCESS is a valid configuration, allow
> > it to be used when using the "full" FIT loading logic in SPL.
> > 
> > Signed-off-by: Francesco Valla <francesco@valla.it>
> > ---
> >   boot/image-fit.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/boot/image-fit.c b/boot/image-fit.c
> > index f3ddee940dbd..347304956a99 100644
> > --- a/boot/image-fit.c
> > +++ b/boot/image-fit.c
> > @@ -2243,7 +2243,7 @@ int fit_image_load(struct bootm_headers *images, ulong addr,
> >   	}
> >   	/* perform any post-processing on the image data */
> > -	if (!tools_build() && IS_ENABLED(CONFIG_FIT_IMAGE_POST_PROCESS))
> > +	if (!tools_build() && CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS))
> 
> I think this can be reduced to
> 
> if (CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS))
> 
> as tools_build() is true when building for the host (tools), and
> CONFIG_IS_ENABLED prepends CONFIG_TOOLS_ when building for the host (tools)
> and we don't have a TOOLS_FIT_IMAGE_POST_PROCESS.
> 

Thanks, I'll check and add this to the v2.

> Cheers,
> Quentin

Regards,
Francesco


  reply	other threads:[~2026-05-07 20:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 20:24 [PATCH 0/5] Enhance the SPL FIT "full" loading logic Francesco Valla
2026-04-28 20:24 ` [PATCH 1/5] boot: fit: fix FIT verification in SPL Francesco Valla
2026-05-04 12:08   ` Simon Glass
2026-04-28 20:24 ` [PATCH 2/5] boot: fit: decompress kernel when " Francesco Valla
2026-05-04 12:08   ` Simon Glass
2026-05-04 17:34     ` Francesco Valla
2026-04-28 20:24 ` [PATCH 3/5] boot: fit: enable FIT image post-processing " Francesco Valla
2026-05-04 12:08   ` Simon Glass
2026-05-07 16:17   ` Quentin Schulz
2026-05-07 20:18     ` Francesco Valla [this message]
2026-04-28 20:24 ` [PATCH 4/5] spl: call ft_board_setup() and ft_system_setup() if enabled Francesco Valla
2026-05-04 12:09   ` Simon Glass
2026-05-04 17:39     ` Francesco Valla
2026-04-28 20:24 ` [PATCH 5/5] spl: fit: add ramdisk load Francesco Valla
2026-05-04 12:09   ` Simon Glass
2026-05-04 17:47     ` Francesco Valla
2026-05-04 12:07 ` [0/5] Enhance the SPL FIT "full" loading logic Simon Glass
2026-05-04 17:32   ` Francesco Valla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afzzakAEtOauxSEw@bywater \
    --to=francesco@valla.it \
    --cc=andrew.goodbody@linaro.org \
    --cc=anshuld@ti.com \
    --cc=d-gole@ti.com \
    --cc=dlechner@baylibre.com \
    --cc=frank-w@public-files.de \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=james.hilliard1@gmail.com \
    --cc=jstephan@baylibre.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=marek.vasut@mailbox.org \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=quentin.schulz@cherry.de \
    --cc=ravi@prevas.dk \
    --cc=richard.genoud@bootlin.com \
    --cc=ronald.wahl@legrand.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wolfgang.wallner@at.abb.com \
    --cc=xypron.glpk@gmx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox