U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: u-boot@lists.denx.de,
	"Christian Pötzsch" <christian.poetzsch@kernkonzept.com>,
	"Adam Lackorzynski" <adam@l4re.org>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Tom Rini" <trini@konsulko.com>
Subject: Re: [PATCH] virtio: Staticize and constify driver ops
Date: Mon, 11 May 2026 23:29:32 +0800	[thread overview]
Message-ID: <agH13MG3dM49c7Uf@google.com> (raw)
In-Reply-To: <20260510171802.56897-1-marek.vasut+renesas@mailbox.org>

On Sun, May 10, 2026 at 07:17:53PM +0200, Marek Vasut wrote:
> Set the ops structure as static const. The structure is not accessible
> from outside of this driver and is not going to be modified at runtime.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

FWIW

Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>

Regards,
Kuan-Wei

> ---
> Cc: "Christian Pötzsch" <christian.poetzsch@kernkonzept.com>
> Cc: Adam Lackorzynski <adam@l4re.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot@lists.denx.de
> ---
>  drivers/virtio/virtio-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio-uclass.c b/drivers/virtio/virtio-uclass.c
> index c36e9e9b3a7..6e4a3d7a7c1 100644
> --- a/drivers/virtio/virtio-uclass.c
> +++ b/drivers/virtio/virtio-uclass.c
> @@ -400,7 +400,7 @@ UCLASS_DRIVER(virtio) = {
>  	.per_device_auto	= sizeof(struct virtio_dev_priv),
>  };
>  
> -struct bootdev_ops virtio_bootdev_ops = {
> +static const struct bootdev_ops virtio_bootdev_ops = {
>  };
>  
>  static const struct udevice_id virtio_bootdev_ids[] = {
> -- 
> 2.53.0
> 
> 

      parent reply	other threads:[~2026-05-11 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 17:17 [PATCH] virtio: Staticize and constify driver ops Marek Vasut
2026-05-11 13:07 ` Simon Glass
2026-05-11 15:29 ` Kuan-Wei Chiu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agH13MG3dM49c7Uf@google.com \
    --to=visitorckw@gmail.com \
    --cc=adam@l4re.org \
    --cc=bmeng.cn@gmail.com \
    --cc=christian.poetzsch@kernkonzept.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox