U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Hiago De Franco <hfranco@baylibre.com>
Cc: u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Tom Rini <trini@konsulko.com>,
	Leo Yu-Chi Liang <ycliang@andestech.com>,
	Kongyang Liu <seashell11234455@gmail.com>
Subject: Re: [PATCH] mmc: cv1800b_sdhci: honor 'no-1-8-v' DT property
Date: Wed, 13 May 2026 19:04:17 +0800	[thread overview]
Message-ID: <agRasadFIfNwO2Zg@shlinux89> (raw)
In-Reply-To: <20260507234836.284918-1-hfranco@baylibre.com>

On Thu, May 07, 2026 at 08:48:36PM -0300, Hiago De Franco wrote:
>CV1800B SDHCI controller does support 1.8V, however, boards like
>MilkV-Duo 256M do not have a VCCIO 1.8V regulator (the bus is wired for
>3.3V only).
>
>These boards set 'no-1-8-v' in their device tree, and mmc_of_parse()
>does respect this property. Later, when sdhci_setup_cfg() is called, it
>reads SDHCI_CAPABILITIES_1 from the hardware and unconditionally adds
>the UHS caps again based on what the controller advertises. Since the
>board cannot switch to 1.8V, the host issues CMD11 (voltage switch
>request), the card transitions, but the bus stays at 3.3V. The SD card
>stops responding until the next power cycle.
>
>Before calling sdhci_setup_cfg(), set the SDHCI_QUIRK_NO_1_8_V quirk
>when 'no-1-8-v' is present. The quirk causes the SDR104/SDR50/DDR50 bits
>to be masked out of the caps, allowing the card to initialize properly.
>
>This matches the pattern used by zynq_sdhci.
>
>Fixes: eb36f28ff721 ("mmc: cv1800b: Add sdhci driver support for cv1800b SoC")
>Signed-off-by: Hiago De Franco <hfranco@baylibre.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

      reply	other threads:[~2026-05-13 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 23:48 [PATCH] mmc: cv1800b_sdhci: honor 'no-1-8-v' DT property Hiago De Franco
2026-05-13 11:04 ` Peng Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agRasadFIfNwO2Zg@shlinux89 \
    --to=peng.fan@oss.nxp.com \
    --cc=hfranco@baylibre.com \
    --cc=jh80.chung@samsung.com \
    --cc=peng.fan@nxp.com \
    --cc=seashell11234455@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox