U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Marko Mäkelä" <marko.makela@iki.fi>
To: Philippe Reynes <philippe.reynes@softathome.com>
Cc: jonny.green@keytechinc.com, raymondmaoca@gmail.com,
	trini@konsulko.com, simon.glass@canonical.com,
	u-boot@lists.denx.de
Subject: Re: [PATCH v5 00/15] add software ecdsa support
Date: Sat, 16 May 2026 20:22:55 +0300	[thread overview]
Message-ID: <agin72spk-usvOVz@kehys.lan> (raw)
In-Reply-To: <20260421210954.1170437-1-philippe.reynes@softathome.com>

Hi Philippe, all,

Tue, Apr 21, 2026 at 11:09:39PM +0200, Philippe Reynes wrote:
>This series adds the support of ecdsa with software
>using mbedtls. So boards without ecdsa hardware may
>also use signature with ecdsa.

Today, I finally tested this patch series on top of Robert Nelson's 
u-boot v2026.01 based fork for BeagleBoard PocketBeagle 2:
https://github.com/beagleboard/u-boot/commit/ef03e35488377a32cdd4f76d1a03ef7f60c798ef

The only conflicts were for copyright comments in some files.

I used the following configuration; this platform enables CONFIG_FIT and 
CONFIG_FIT_VERIFY by default:

make am62_pocketbeagle2_a53_defconfig
scripts/config -e ASYMMETRIC_KEY_TYPE -e ASYMMETRIC_PUBLIC_KEY_SUBTYPE \
-d LEGACY_HASHING_AND_CRYPTO -e MBEDTLS_LIB -e MBEDTLS_LIB_CRYPTO \
-e ECDSA -e ECDSA_MBEDTLS -e ECDSA_VERIFY \
-d MD5_MBEDTLS -d HKDF_MBEDTLS -e SHA256_SMALLER -e SHA512_SMALLER \
-d RSA_PUBLIC_KEY_PARSER -d RSA_PUBLIC_KEY_PARSER_MBEDTLS \
-d SPL_ECDSA_VERIFY \
-d SPL_ASYMMETRIC_KEY_TYPE -d SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE \
-d SPL_RSA_PUBLIC_KEY_PARSER \
-d PKCS7_MESSAGE_PARSER -d PKCS7_MESSAGE_PARSER_MBEDTLS \
-e X509_CERTIFICATE_PARSER -d MSCODE_PARSER

I used these settings also for the 32-bit 
am62_pocketbeagle2_r5_defconfig which loads the 64-bit u-boot.img.

I tested this build with an ARMv8 "defconfig" of 
https://github.com/torvalds/linux tag v7.0. An image that was signed 
with a different private key was rejected:

=> load mmc 1 $loadaddr fitImage
15013689 bytes read in 180 ms (79.5 MiB/s)
=> source
## Executing script at 82000000
sha256,ecdsa256:dev-  error!
Verification failed for '<NULL>' hash node in 'conf-1' config node
Failed to verify required signature 'dev'
=> bootm
## Loading kernel (any) from FIT Image at 82000000 ...
    Using 'conf-1' configuration
    Verifying Hash Integrity ... sha256,ecdsa256:dev-  error!
Verification failed for '<NULL>' hash node in 'conf-1' config node
Failed to verify required signature 'dev'
Bad Data Hash
ERROR -2: can't get kernel image!

A correctly signed image passed the verification:

=> load mmc 1 $loadaddr fitImage
15013689 bytes read in 179 ms (80 MiB/s)
=> bootm
## Loading kernel (any) from FIT Image at 82000000 ...
[snip]
    Loading fdt from 0x82e430d4 to 0x88000000
    Booting using the fdt blob at 0x88000000
Working FDT set to 88000000
    Uncompressing Kernel Image to 82000000
Error: inflate() returned -3
gzip compressed: uncompress error -3
Must RESET board to recover
Resetting the board...
U-Boot SPL 2026.01 (May 16 2026 - 16:42:03 +0000)

I think that this can be declared as a success for this patch series, 
even though my kernel load address is causing trouble.

With best regards,

	Marko

      parent reply	other threads:[~2026-05-16 17:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 21:09 [PATCH v5 00/15] add software ecdsa support Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 01/15] ecdsa: fix support of secp521r1 Philippe Reynes
2026-04-22  0:11   ` Simon Glass
2026-04-22 18:32   ` Raymond Mao
2026-05-16 17:09     ` Marko Mäkelä
2026-05-20 23:04       ` Simon Glass
2026-04-21 21:09 ` [PATCH v5 02/15] mbedtls: enable support of ecc Philippe Reynes
2026-04-22  0:10   ` Simon Glass
2026-04-22 18:15   ` Raymond Mao
2026-04-21 21:09 ` [PATCH v5 03/15] ecdsa: initial support of ecdsa using mbedtls Philippe Reynes
2026-04-22  0:10   ` Simon Glass
2026-04-22 18:17   ` Raymond Mao
2026-04-21 21:09 ` [PATCH v5 04/15] test: lib: ecdsa: add initial test Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 05/15] drivers: crypto: add software ecdsa support Philippe Reynes
2026-04-22  0:12   ` Simon Glass
2026-04-21 21:09 ` [PATCH v5 06/15] test: dm: ecdsa.c: clean this test as software ecdsa is now implemented Philippe Reynes
2026-04-22  0:12   ` Simon Glass
2026-04-21 21:09 ` [PATCH v5 07/15] test: py: vboot: prepare integration test for ecdsa Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 08/15] test: vboot: add " Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 09/15] tools: fit_image_setup_sig: set required_keynode to -1 Philippe Reynes
2026-04-22  0:13   ` Simon Glass
2026-04-21 21:09 ` [PATCH v5 10/15] tools: mkimage: pre-load: add support of ecdsa Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 11/15] tools: binman: " Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 12/15] boot: " Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 13/15] tools: preload_check_sign: " Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 14/15] test: py: vboot: prepare test for global signature with ecdsa Philippe Reynes
2026-04-21 21:09 ` [PATCH v5 15/15] test: py: vboot: add " Philippe Reynes
2026-04-22 14:54 ` [PATCH v5 00/15] add software ecdsa support Raymond Mao
2026-05-16 17:22 ` Marko Mäkelä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agin72spk-usvOVz@kehys.lan \
    --to=marko.makela@iki.fi \
    --cc=jonny.green@keytechinc.com \
    --cc=philippe.reynes@softathome.com \
    --cc=raymondmaoca@gmail.com \
    --cc=simon.glass@canonical.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox