Re: [PATCH 0/2] efi: fix and test hii keyboard layout pointer computation

["Vincent Stehlé" <vincent.stehle@arm.com>]

On Tue, May 12, 2026 at 09:05:29PM +0200, Heinrich Schuchardt wrote:
> Am 12. Mai 2026 19:40:32 MESZ schrieb "Vincent Stehlé" <vincent.stehle@arm.com>:
> >- Fix one scaled pointer arithmetic bug in EFI Loader HII implementation.
> >- Enhance the existing EFI HII unit test to catch the bug.
> >
> >The unit test can run on the sandbox with the following command:
> >
> >  ./u-boot -T -c "setenv efi_selftest HII database protocols; \
> >		  bootefi selftest"
> >
> >Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
> >---
> >Vincent Stehlé (2):
> >      efi_loader: fix hii keyboard layout pointer computation
> >      efi_selftest: test hii keyboard layouts more
> >
> > lib/efi_loader/efi_hii.c                 |  3 +-
> > lib/efi_selftest/efi_selftest_hii.c      | 67 ++++++++++++++++++--------------
> > lib/efi_selftest/efi_selftest_hii_data.c | 12 ++++++
> > 3 files changed, 51 insertions(+), 31 deletions(-)
> >---
> >base-commit: 5732bd0f457b4c671e46574d64d4acb099c0f0a5
> >change-id: 20260512-layout-pointer-29d1cd52c070
> >
> >Best regards,
> 
> Hello Vincent,
> 
> Off the list:
> 
> Did you find any real use for HII protocols in U-Boot except for running the SCT?
> 
> Are HII based EFI applications a thing?

Hi Heinrich,

A fair question indeed, as the HII protocols do not seem to be used that much in
practice.

The UEFI Shell seems to be using them, though, which should be a sufficient
reason to support them, I think.

Those protocols are used as well a little in systemd-boot and iPXE for example,
but as far as I can tell, they are not used at all in Shim, GRUB, Linux, Xen,
the BSDs or Android GBL.

Best regards,
Vincent.

> 
> Best regards
> 
> Heinrich