From: Peng Fan <peng.fan@oss.nxp.com>
To: Aristo Chen <aristo.chen@canonical.com>
Cc: u-boot@lists.denx.de, Fabio Estevam <festevam@gmail.com>,
Peng Fan <peng.fan@nxp.com>, Stefano Babic <sbabic@nabladev.com>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
Tom Rini <trini@konsulko.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>
Subject: Re: [PATCH v1 3/3] mx6sabre: Move environment variables to .env files
Date: Thu, 11 Jun 2026 12:15:49 +0800 [thread overview]
Message-ID: <aio2dZj+xjIFjO2D@shlinux89> (raw)
In-Reply-To: <20260610133336.15999-4-aristo.chen@canonical.com>
On Wed, Jun 10, 2026 at 01:24:24PM +0000, Aristo Chen wrote:
>Move the shared environment from CFG_EXTRA_ENV_SETTINGS in
>mx6sabre_common.h to a common text environment fragment in
>include/env/nxp/mx6sabre_common.env. The mx6sabresd and mx6sabreauto
>board environments include this fragment and add their own console
>setting, which is the only board specific difference between them. The
>eMMC firmware update variables remain guarded by CONFIG_SUPPORT_EMMC_BOOT
>inside the fragment. The now unused CONSOLE_DEV defines and the
>linux/stringify.h include are dropped.
>
>The generated default environment is unchanged for both boards. This was
>verified by comparing the output of scripts/get_default_envs.sh before
>and after the change, which produced identical results.
>
>Signed-off-by: Aristo Chen <aristo.chen@canonical.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
prev parent reply other threads:[~2026-06-11 4:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 13:24 [PATCH v1 0/3] Move NXP i.MX board environments to .env files Aristo Chen
2026-06-10 13:24 ` [PATCH v1 1/3] mx7ulp_evk: Move environment variables to .env file Aristo Chen
2026-06-11 4:14 ` Peng Fan
2026-06-10 13:24 ` [PATCH v1 2/3] mx6ullevk: " Aristo Chen
2026-06-11 4:15 ` Peng Fan
2026-06-10 13:24 ` [PATCH v1 3/3] mx6sabre: Move environment variables to .env files Aristo Chen
2026-06-11 4:15 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aio2dZj+xjIFjO2D@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=aristo.chen@canonical.com \
--cc=festevam@gmail.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=peng.fan@nxp.com \
--cc=sbabic@nabladev.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox