From: Peng Fan <peng.fan@oss.nxp.com>
To: Marek Vasut <marex@nabladev.com>
Cc: Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>,
trini@konsulko.com, Jaehoon Chung <jh80.chung@samsung.com>,
Tze Yee Ng <tze.yee.ng@altera.com>
Subject: Re: [PATCH] Revert "mmc: sdhci-cadence: trigger tuning for SD HS mode on SD6HC (v6) PHY"
Date: Mon, 29 Jun 2026 10:02:57 +0800 [thread overview]
Message-ID: <akHSUfUHLz4L7fvG@shlinux89> (raw)
In-Reply-To: <6f745e04-2978-4474-940e-4cafd6f61851@nabladev.com>
On Sun, Jun 28, 2026 at 10:21:07PM +0200, Marek Vasut wrote:
>On 6/28/26 8:57 PM, Tanmay Kathpalia wrote:
>> This reverts commit b42c67188c14 ("mmc: sdhci-cadence: trigger tuning
>> for SD HS mode on SD6HC (v6) PHY").
>>
>> The reverted patch added runtime DLL delay calibration for SD High
>> Speed mode on the Cadence SD6HC (v6) PHY, gated by the device tree
>> property "cdns,sd-hs-tuning". Reviewer feedback identified issues with
>> the implementation, but the patch was merged without those concerns
>> being adequately addressed or justified.
>>
>> Reverting to realign the driver with the IP documentation and the SD
>> Physical Layer Specification, as the underlying issue requires a
>> different solution approach.
>It would be good if the commit message went into details of those issues and
>explained the reasoning behind the revert. I.e. include details please.
+1
prev parent reply other threads:[~2026-06-29 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 18:57 [PATCH] Revert "mmc: sdhci-cadence: trigger tuning for SD HS mode on SD6HC (v6) PHY" Tanmay Kathpalia
2026-06-28 20:21 ` Marek Vasut
2026-06-29 2:02 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akHSUfUHLz4L7fvG@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=jh80.chung@samsung.com \
--cc=marex@nabladev.com \
--cc=peng.fan@nxp.com \
--cc=tanmay.kathpalia@altera.com \
--cc=trini@konsulko.com \
--cc=tze.yee.ng@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox