From: Peng Fan <peng.fan@oss.nxp.com>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: Peng Fan <peng.fan@nxp.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Tom Rini <trini@konsulko.com>,
Kaustabh Chakraborty <kauschluss@disroot.org>,
Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH 3/4] mmc: dw_mmc: Allow use of in-spec voltage range for vqmmc-supply
Date: Mon, 29 Jun 2026 13:27:07 +0800 [thread overview]
Message-ID: <akICK2m6uxqKdc33@shlinux89> (raw)
In-Reply-To: <20260628102527.1247889-4-jonas@kwiboo.se>
On Sun, Jun 28, 2026 at 10:25:25AM +0000, Jonas Karlman wrote:
>The Rockchip RK3399 SoC SDMMC IO domain supports 1.8V and 3.0V mode, and
>the 3.0V mode is within SD Standards allowed 2.7V-3.6V range. However,
>the commit 0b75109b6aaf ("mmc: dw_mmc: return error for invalid voltage
>setting") help enforce strict 1.8V and 3.3V when setting vqmmc-supply
>making mmc_set_signal_voltage() now fail for MMC_SIGNAL_VOLTAGE_330 and
>leading to an improper switch to MMC_SIGNAL_VOLTAGE_180.
>
>Use regulator_set_value_clamp() to set an SD Standards voltage range,
>1.70V-1.95V and 2.7V-3.6V, I/O voltage instead of requiring an exact
>regulator value to closer match Linux and to fix use of 3.3V signal
>voltage on Rockchip RK3399 boards using MMC_IO_VOLTAGE=y.
>
>Fixes: 0b75109b6aaf ("mmc: dw_mmc: return error for invalid voltage setting")
>Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
next prev parent reply other threads:[~2026-06-29 5:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 10:25 [PATCH 0/4] mmc: dw_mmc: Allow use of in-spec voltage range for vqmmc-supply Jonas Karlman
2026-06-28 10:25 ` [PATCH 1/4] power: regulator: Add helper to set voltage within an acceptable range Jonas Karlman
2026-06-29 5:21 ` Peng Fan
2026-06-28 10:25 ` [PATCH 2/4] test: dm: regulator: Add regulator_set_value_clamp() tests Jonas Karlman
2026-06-29 5:31 ` Peng Fan
2026-06-28 10:25 ` [PATCH 3/4] mmc: dw_mmc: Allow use of in-spec voltage range for vqmmc-supply Jonas Karlman
2026-06-29 5:27 ` Peng Fan [this message]
2026-06-28 10:25 ` [PATCH 4/4] mmc: sdhci: Use CONFIG_IS_ENABLED for MMC_IO_VOLTAGE Jonas Karlman
2026-06-29 5:31 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akICK2m6uxqKdc33@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=jh80.chung@samsung.com \
--cc=jonas@kwiboo.se \
--cc=kauschluss@disroot.org \
--cc=peng.fan@nxp.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox