U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
To: Tom Rini <trini@konsulko.com>
Cc: Quentin Schulz <quentin.schulz@cherry.de>,
	casey.connolly@linaro.org, neil.armstrong@linaro.org,
	sumit.garg@kernel.org, me@samcday.com,
	aswin.murugan@oss.qualcomm.com, u-boot-qcom@groups.io,
	Sumit Garg <sumit.garg@oss.qualcomm.com>,
	jerome@forissier.org, marek.vasut+renesas@mailbox.org,
	ilias.apalodimas@linaro.org, clamor95@gmail.com,
	michal.simek@amd.com, u-boot@lists.denx.de
Subject: Re: [PATCH v6 3/5] sysreset: Implement PSCI based reset to EDL mode for QCOM SoCs
Date: Fri, 3 Jul 2026 12:58:37 +0530	[thread overview]
Message-ID: <akdkpczZxCWRvBm+@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <akdG1STYeiKYRjZo@hu-varada-blr.qualcomm.com>

On Fri, Jul 03, 2026 at 10:51:37AM +0530, Varadarajan Narayanan wrote:
> Quentin Schulz/Tom Rini,
>
> [ . . . ]
>
> > > > > > The issue is that the first sysreset device implementing the request_arg
> > > > > > callback will consume the args and return EPROTONOSUPPORT which will
> > > > > > stop the loop.
> > > > > >
> > > > > > Think about multiple sysreset devices, and let's say we have a new '-
> > > > > > dummy' argument to the reset CLI command, then it'll depend on the
> > > > > > registration order of the sysreset driver whether the dummy argument
> > > > > > will be handled by the qcom driver which will return -
> > > > > > EPROTONOSUPPORT since it isn't '-edl', or by the dummy sysreset driver.
> > > > > >
> > > > > > I think we should have a fourth possible return code which is "I don't
> > > > > > know how to handle this argument", e.g. à-la IRQ_NONE in Linux kernel
> > > > > > for interrupts that aren't for the device this IRQ handler was triggered
> > > > > > for. Or maybe we should really be using -EPROTONOSUPPORT for that
> > > > > > meaning and not exit the loop if that's the return code?
> > > > > >
> > > > > > Or maybe I misread or misunderstood the code?
> > > >
> > > > Following up here.
> > > >
> > >
> > > Do we end up reverting just before the release then?
> >
> > Please send it out, cc everyone, and see if that gets some response?
>
> Sorry about the delay. Will post a change shortly.

Please review [1]

Thanks
Varada

1 - https://lore.kernel.org/u-boot/20260703-walk-arg-fix-v1-1-64beca00d7e2@oss.qualcomm.com/

  reply	other threads:[~2026-07-03  7:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21  6:39 [PATCH v6 0/5] Implement reset to EDL for qcs9100 Varadarajan Narayanan
2026-01-21  6:39 ` [PATCH v6 1/5] arm: psci: Add API to check for support of specific PSCI function Varadarajan Narayanan
2026-01-21  6:39 ` [PATCH v6 2/5] drivers: sysreset: Add sysreset op that can take arguments Varadarajan Narayanan
2026-01-21 14:57   ` Tom Rini
2026-01-26  5:15   ` Simon Glass
2026-01-27  4:18     ` Varadarajan Narayanan
2026-02-04  0:23       ` Simon Glass
2026-02-13  9:42         ` Varadarajan Narayanan
2026-02-13 20:20           ` Simon Glass
2026-02-16  5:31             ` Varadarajan Narayanan
2026-02-16 15:29               ` Tom Rini
2026-02-17  4:26                 ` Varadarajan Narayanan
2026-02-17 14:39                   ` Tom Rini
2026-02-16 17:19               ` Simon Glass
2026-02-17  4:24                 ` Varadarajan Narayanan
2026-02-17 13:31                   ` Simon Glass
2026-01-21  6:39 ` [PATCH v6 3/5] sysreset: Implement PSCI based reset to EDL mode for QCOM SoCs Varadarajan Narayanan
2026-05-26 13:32   ` Quentin Schulz
2026-06-08 14:53     ` Quentin Schulz
2026-06-23 16:50       ` Tom Rini
2026-07-02 17:43         ` Quentin Schulz
2026-07-02 17:46           ` Tom Rini
2026-07-03  5:21             ` Varadarajan Narayanan
2026-07-03  7:28               ` Varadarajan Narayanan [this message]
2026-01-21  6:39 ` [PATCH v6 4/5] cmd: boot: Add '-edl' option to reset command documentation Varadarajan Narayanan
2026-01-21  6:39 ` [PATCH v6 5/5] qcom_defconfig: enable psci based sysreset Varadarajan Narayanan
2026-04-29  8:49 ` [PATCH v6 0/5] Implement reset to EDL for qcs9100 Casey Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akdkpczZxCWRvBm+@hu-varada-blr.qualcomm.com \
    --to=varadarajan.narayanan@oss.qualcomm.com \
    --cc=aswin.murugan@oss.qualcomm.com \
    --cc=casey.connolly@linaro.org \
    --cc=clamor95@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jerome@forissier.org \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=me@samcday.com \
    --cc=michal.simek@amd.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quentin.schulz@cherry.de \
    --cc=sumit.garg@kernel.org \
    --cc=sumit.garg@oss.qualcomm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox