From: Vincent Jardin <vjardin@free.fr>
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: u-boot@lists.denx.de, Alexey Charkov <alchark@gmail.com>,
Andrew Goodbody <andrew.goodbody@linaro.org>,
David Lechner <dlechner@baylibre.com>,
Dinesh Maniyam <dinesh.maniyam@altera.com>,
Heiko Schocher <hs@nabladev.com>,
Heiko Stuebner <heiko@sntech.de>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jerome Forissier <jerome.forissier@arm.com>,
Julien Stephan <jstephan@baylibre.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
Marek Vasut <marek.vasut@mailbox.org>,
Michael Trimarchi <michael@amarulasolutions.com>,
Michal Simek <michal.simek@amd.com>,
Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Neil Armstrong <neil.armstrong@linaro.org>,
Peng Fan <peng.fan@nxp.com>,
Peter Robinson <pbrobinson@gmail.com>,
Philip Molloy <philip.molloy@analog.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Raymond Mao <raymond.mao@riscstar.com>,
Simon Glass <sjg@chromium.org>,
Stefan Roese <stefan.roese@mailbox.org>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2 1/7] pmbus: add PMBus 1.x framework, CLI, and binding
Date: Mon, 6 Jul 2026 12:27:34 +0200 [thread overview]
Message-ID: <akuDFra441oqsoQM@L30177.local> (raw)
In-Reply-To: <aksi3r4myOt-Meqh@nxa18884-linux-1.ap.freescale.net>
Hi Peng,
Below some feedbacks on you reviews. More will be provided into
a v3.
> >+ if (pmbus_read_string(chip, reg, s, sizeof(s),
> >+ act->info ? false : false) >= 0)
>
> Should be true : false or false: true?
hmm ;) it is a leftover, I'll clean it.
> >+ ret = dm_i2c_read(dev, cmd, raw, len + 1);
>
> When len is 16, len + 1 bytes are read, so corrupt u8 raw[].
right, I'll improve it for v3, thanks for detecting it.
best regards,
Vincent
next prev parent reply other threads:[~2026-07-06 10:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <"<20260702171618.1773206-1-vjardin@free.fr>
2026-07-02 19:56 ` [PATCH v2 0/7] pmbus: PMBus 1.x framework, CLI, regulator and thermal support Vincent Jardin
2026-07-02 19:56 ` [PATCH v2 1/7] pmbus: add PMBus 1.x framework, CLI, and binding Vincent Jardin
2026-07-06 3:37 ` Peng Fan
2026-07-06 10:27 ` Vincent Jardin [this message]
2026-07-02 20:07 ` [PATCH v2 2/7] power: regulator: add generic PMBus UCLASS_REGULATOR adapter Vincent Jardin
2026-07-02 20:14 ` [PATCH v2 3/7] power: regulator: add MPS MPQ8785 PMBus regulator driver Vincent Jardin
2026-07-06 3:43 ` Peng Fan
2026-07-06 10:24 ` Vincent Jardin
2026-07-02 20:15 ` [PATCH v2 4/7] board: nxp: vid: introduce PMBus framework support Vincent Jardin
2026-07-06 3:41 ` Peng Fan
2026-07-06 10:32 ` Vincent Jardin
2026-07-02 22:26 ` [PATCH v2 5/7] thermal: pmbus: add PMBus die-temp driver Vincent Jardin
2026-07-02 22:56 ` [PATCH v2 6/7] test: dm: pmbus: add a sandbox PMBus chip emulator Vincent Jardin
2026-07-02 22:57 ` [PATCH v2 7/7] test: dm: pmbus: test pmbus command and framework Vincent Jardin
2026-07-02 17:15 [PATCH v1 0/7] pmbus: PMBus 1.x framework, CLI, regulator and thermal support Vincent Jardin
2026-07-02 17:15 ` [PATCH v1 1/7] pmbus: add PMBus 1.x framework, CLI, and binding Vincent Jardin
2026-07-02 17:15 ` [PATCH v1 2/7] power: regulator: add generic PMBus UCLASS_REGULATOR adapter Vincent Jardin
2026-07-02 17:15 ` [PATCH v1 3/7] power: regulator: add MPS MPQ8785 PMBus regulator driver Vincent Jardin
2026-07-02 17:15 ` [PATCH v1 4/7] board: nxp: vid: introduce PMBus framework support Vincent Jardin
2026-07-02 17:15 ` [PATCH v1 5/7] thermal: pmbus: add PMBus die-temp driver Vincent Jardin
2026-07-02 17:15 ` [PATCH v1 6/7] test: dm: pmbus: add a sandbox PMBus chip emulator Vincent Jardin
2026-07-02 17:26 ` [PATCH v1 0/7] pmbus: PMBus 1.x framework, CLI, regulator and thermal support Tom Rini
2026-07-02 23:06 ` Vincent Jardin
2026-07-02 17:46 ` [PATCH v1 7/7] test: dm: pmbus: test pmbus command and framework Vincent Jardin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akuDFra441oqsoQM@L30177.local \
--to=vjardin@free.fr \
--cc=alchark@gmail.com \
--cc=andrew.goodbody@linaro.org \
--cc=dinesh.maniyam@altera.com \
--cc=dlechner@baylibre.com \
--cc=heiko@sntech.de \
--cc=hs@nabladev.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@arm.com \
--cc=jstephan@baylibre.com \
--cc=kory.maincent@bootlin.com \
--cc=marek.vasut@mailbox.org \
--cc=michael@amarulasolutions.com \
--cc=michal.simek@amd.com \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=neil.armstrong@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=philip.molloy@analog.com \
--cc=quentin.schulz@cherry.de \
--cc=raymond.mao@riscstar.com \
--cc=sjg@chromium.org \
--cc=stefan.roese@mailbox.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=visitorckw@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox