From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert P. J. Day Date: Sun, 3 Feb 2013 04:08:19 -0500 (EST) Subject: [U-Boot] [PATCH] cmd_mem.c: Fix simple typoes, no functional changes. In-Reply-To: <510D67C9.5010709@myspectrum.nl> References: <510D67C9.5010709@myspectrum.nl> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, 2 Feb 2013, Jeroen Hofstee wrote: > On 02/02/2013 05:04 PM, Robert P. J. Day wrote: > > Signed-off-by: Robert P. J. Day > > > > --- > > > > based on perusal of entire file as i was reading code. undoubtedly > > more of these file-wide proofreads coming if no objections ... > > > > diff --git a/common/cmd_mem.c b/common/cmd_mem.c > > index 0f3ffc8..2568c04 100644 > > --- a/common/cmd_mem.c > > +++ b/common/cmd_mem.c > > @@ -462,7 +462,7 @@ static int do_mem_loop(cmd_tbl_t *cmdtp, int flag, int > > argc, > > if (argc < 3) > > return CMD_RET_USAGE; > > > > - /* Check for a size spefication. > > + /* Check for a size specification. > > * Defaults to long if no or incorrect specification. > > */ > > if ((size = cmd_get_data_size(argv[0], 4)) < 0) .. snip ... > nitpicking: the summary line should not end with a dot. point taken, i can resubmit. > multi line comments in u-boot are commonly > > /* > * I span > * multiple lines > */ > > So while at it, you might want to add the empty opening line as well. in cases like this, it's kind of a judgment call. if that's truly a strict standard, then sure. but i'm pretty sure there's a *lot* of the above type of comment in the source and when i'm just fixing comments, i prefer to make as unobtrusive a change as possible. i'll let wolfgang decide, and i'll go with whatever he chooses. note carefully that you used the phrase "commonly", without claiming that it's a hard and fast standard, which is why i left it alone. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================