public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Robert P. J. Day <rpjday@crashcourse.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
Date: Thu, 19 Nov 2009 21:29:01 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0911192128300.10542@localhost> (raw)
In-Reply-To: <yw1xskca7xld.fsf@unicorn.mansr.com>

On Fri, 20 Nov 2009, M?ns Rullg?rd wrote:

> "Robert P. J. Day" <rpjday@crashcourse.ca> writes:
>
> > Make it clear to a reader that the user of OMAP34XX macros in the
> > (OMAP 3530-based) beagle config file is just fine.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> >   i'll let dirk be the judge as to whether this is worth adding, or if
> > he'd prefer a different phrasing.
> >
> > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> > index 19a5ec9..9a03587 100644
> > --- a/include/configs/omap3_beagle.h
> > +++ b/include/configs/omap3_beagle.h
> > @@ -30,6 +30,9 @@
> >
> >  /*
> >   * High Level Configuration Options
> > + *
> > + * Note that, although the BeagleBoard incorporates an OMAP 3530,
> > + * it's currently still valid to use OMAP34XX preprocessor values.
> >   */
> >  #define CONFIG_ARMCORTEXA8	1	/* This is an ARM V7 CPU core */
> >  #define CONFIG_OMAP		1	/* in a TI OMAP core */
>
> Since 34xx and 35xx are in fact exactly the same silicon, saying it is
> "currently" valid seems a bit odd.  This sort of implies a planned
> change.

  ok, i can rephrase that.  i was working off of a post by dirk a
couple days ago where he seemed to be suggesting that the door was
open for some divergence down the road, but maybe i just misread.
will fix shortly.

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

      parent reply	other threads:[~2009-11-20  2:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20  2:03 [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros Robert P. J. Day
2009-11-20  2:13 ` Måns Rullgård
2009-11-20  2:21   ` Nishanth Menon
2009-11-20  2:36     ` Robert P. J. Day
2009-11-20 10:31       ` Måns Rullgård
2009-11-20  2:29   ` Robert P. J. Day [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0911192128300.10542@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox