public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Robert P. J. Day <rpjday@crashcourse.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
Date: Fri, 20 Nov 2009 09:59:40 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0911200957490.27635@localhost> (raw)
In-Reply-To: <4B069C13.6060807@windriver.com>

On Fri, 20 Nov 2009, Tom wrote:

> Robert P. J. Day wrote:
> > Make it clear to the reader that, since OMAP 34XX and 35XX are the
> > same silicon, the BeagleBoard can use the OMAP34XX macros.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> > index 19a5ec9..59b7edc 100644
> > --- a/include/configs/omap3_beagle.h
> > +++ b/include/configs/omap3_beagle.h
> > @@ -30,6 +30,9 @@
> >
> >  /*
> >   * High Level Configuration Options
> > + *
> > + * Note that since OMAP 34XX and 35XX are the same silicon, the
> > + * OMAP 3530-based BeagleBoard can use the OMAP34XX macros.
>
> I think this comment would be appropriate in the omap3 readme.
>
> <beyond_scope_of_change>
> Perhaps the omap3 specific defines could be explained in
> greater detail there.
> </beyond_scope_of_change>

  certainly, there's nothing amiss about a longer explanation in the
README file.  but the rationale for the above was just a couple lines
to prevent any confusion on the part of anyone who wanted to peruse
the beagle config file, nothing more.  it wasn't meant to be a big
deal.

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

      reply	other threads:[~2009-11-20 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20  2:34 [U-Boot] [PATCH v2] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros Robert P. J. Day
2009-11-20 13:39 ` Tom
2009-11-20 14:59   ` Robert P. J. Day [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0911200957490.27635@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox