public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] difference between V_PROMPT and CONFIG_SYS_PROMPT?
@ 2009-11-19  8:00 Robert P. J. Day
  2009-12-07 20:22 ` Wolfgang Denk
  0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2009-11-19  8:00 UTC (permalink / raw)
  To: u-boot


  another beginner-level question, i'm sure, but what's the
distinction between V_PROMPT and CONFIG_SYS_PROMPT for customizing the
u-boot prompt?

  based on the output from a straightforward grep, it appears that
every example of customizing the prompt has the form:

#define V_PROMPT                "OMAP3_EVM # "
... snip ...
#define CONFIG_SYS_PROMPT               V_PROMPT

as in, V_PROMPT is set, for no other reason than to subsequently set
CONFIG_SYS_PROMPT a few lines later, at which point V_PROMPT never
seems to be used again.

  is this just a historical holdover?  any reason why
CONFIG_SYS_PROMPT can't be set directly and V_PROMPT ignored/removed?

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] difference between V_PROMPT and CONFIG_SYS_PROMPT?
  2009-11-19  8:00 [U-Boot] difference between V_PROMPT and CONFIG_SYS_PROMPT? Robert P. J. Day
@ 2009-12-07 20:22 ` Wolfgang Denk
  2009-12-08  8:53   ` Robert P. J. Day
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2009-12-07 20:22 UTC (permalink / raw)
  To: u-boot

Dear "Robert P. J. Day",

In message <alpine.LFD.2.00.0911190255590.29408@localhost> you wrote:
> 
>   another beginner-level question, i'm sure, but what's the
> distinction between V_PROMPT and CONFIG_SYS_PROMPT for customizing the
> u-boot prompt?

The difference is that CONFIG_SYS_PROMPT (which probably should be
renamed into CONFIG_PROMPT) is an official, documented configuration
option, while V_PROMPT is a private and apparently redundant
definition that should be removed.

Cleanup patches welcome.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quantum Mechanics is God's version of "Trust me."

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] difference between V_PROMPT and CONFIG_SYS_PROMPT?
  2009-12-07 20:22 ` Wolfgang Denk
@ 2009-12-08  8:53   ` Robert P. J. Day
  0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2009-12-08  8:53 UTC (permalink / raw)
  To: u-boot

On Mon, 7 Dec 2009, Wolfgang Denk wrote:

> Dear "Robert P. J. Day",
>
> In message <alpine.LFD.2.00.0911190255590.29408@localhost> you wrote:
> >
> >   another beginner-level question, i'm sure, but what's the
> > distinction between V_PROMPT and CONFIG_SYS_PROMPT for customizing
> > the u-boot prompt?
>
> The difference is that CONFIG_SYS_PROMPT (which probably should be
> renamed into CONFIG_PROMPT) is an official, documented configuration
> option, while V_PROMPT is a private and apparently redundant
> definition that should be removed.
>
> Cleanup patches welcome.

  submitted.  if CONFIG_SYS_PROMPT really should be renamed, that can
be done in a followup patch as a separate logical action.

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-12-08  8:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-19  8:00 [U-Boot] difference between V_PROMPT and CONFIG_SYS_PROMPT? Robert P. J. Day
2009-12-07 20:22 ` Wolfgang Denk
2009-12-08  8:53   ` Robert P. J. Day

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox