From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert P. J. Day Date: Mon, 28 Dec 2015 08:02:26 -0500 (EST) Subject: [U-Boot] any value in moving ATA/SATA stuff from drivers/block to headers? Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de currently poking around in drivers/block, adding a driver for another silicon image drive, and noticed that sata_sil3114.h has some content that looks more appropriate for a generic ATA/SATA header file. for example, this snippet: /* Missing ata defines */ #define ATA_CMD_STANDBY 0xE2 #define ATA_CMD_STANDBYNOW1 0xE0 #define ATA_CMD_IDLE 0xE3 #define ATA_CMD_IDLEIMMEDIATE 0xE1 seems already covered by include/libata.h, while the earlier structure definitions in that file: struct sata_ioports { ... snip ... }; struct sata_port { ... snip ... }; also look like they could be moved to a generic SATA-related header file. does that make any sense or sound like it has any value? rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================