U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Robert P. J. Day <rpjday@crashcourse.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot] wanting to confirm i'm setting the MAC address the right way
Date: Wed, 25 May 2016 06:09:07 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.20.1605250557170.20728@localhost.localdomain> (raw)
In-Reply-To: <CAEUhbmWUNcwcTMt+A_jVPBLq=Buo53ox11HQKffAxzqsjfn4PQ@mail.gmail.com>

On Wed, 25 May 2016, Bin Meng wrote:

> On Wed, May 25, 2016 at 12:31 AM, Robert P. J. Day
> <rpjday@crashcourse.ca> wrote:
> >
> >   i want to use the fdt_fixup_ethernet() routine to automate most
> > of the work of setting the MAC address in the FDT before passing
> > it to the kernel, so here's what i'm about to do, and i'd
> > appreciate someone saying, "yup, looks good" if it will indeed
> > work.
> >
> >   on either a MPC8280 or MPC8360 system, i will first set up the
> > DTS file with some variation of:
>
> To make it clear, the DTS file is the Linux kernel's, not U-Boot's.

  right, i knew that, should have been clearer.

> >         aliases {
> >                 ethernet0 = &ucc0;
> >         };
> >
> >         ... snip ...
> >
> >                 ucc0:ucc at 2000 {
> >                         device_type = "network";
> >                         compatible = "ucc_geth";
> >                         model = "UCC";
> >                         device-id = <1>;
> >                         reg = <0x2000 0x200>;
> >                         interrupts = <0x20>;
> >                         local-mac-address = [ 00 01 02 03 04 05 ];
>
> Make it all 00s

  point taken, as i see numerous other examples which also add a
comment "Filled in by U-Boot", which never hurts.

... snip ...

> > is that about it? it *looks* like all i have to do, and
> > fdt_fixup_etherhet() will do all the rest.
>
> yup, looks good :)

thanks.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

      reply	other threads:[~2016-05-25 10:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 16:31 [U-Boot] wanting to confirm i'm setting the MAC address the right way Robert P. J. Day
2016-05-25  2:18 ` Bin Meng
2016-05-25 10:09   ` Robert P. J. Day [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1605250557170.20728@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox