U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Mukhin via U-Boot <u-boot@lists.u-boot-project.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
	Denis Mukhin <dmukhin@ford.com>,
	u-boot@lists.u-boot-project.org
Subject: Re: [PATCH 1/1] sandbox: fix enum host_platform_flags description
Date: Mon, 27 Jul 2026 10:29:00 -0700	[thread overview]
Message-ID: <ameVXBb54ICYdIl3@kraken> (raw)
In-Reply-To: <20260727170022.13258-1-heinrich.schuchardt@canonical.com>

On Mon, Jul 27, 2026 at 07:00:22PM +0200, Heinrich Schuchardt via U-Boot wrote:
> `make htmldocs` reports
> 
>     ./include/sandbox_host.h:14: warning:
>     cannot understand function prototype: 'enum host_platform_flags '
> 
> Align the description with Sphinx style.
> 
> Fixes: 93e9af685fef ("test: bootdev: scan with a broken high-priority device")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Thanks for the fix!

> ---
>  include/sandbox_host.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/include/sandbox_host.h b/include/sandbox_host.h
> index 1330358ef7a..8329cbba537 100644
> --- a/include/sandbox_host.h
> +++ b/include/sandbox_host.h
> @@ -9,10 +9,12 @@
>  #define __SANDBOX_HOST__
>  
>  /**
> - * Device flags.
> + * enum host_platform_flags - device flags
> + *
>   */
>  enum host_platform_flags {
> -	HOST_FLAG_BROKEN		= BIT(0), /** Simulate broken device */
> +	/** @HOST_FLAG_BROKEN:	simulate boken device */

                                     ^^ typo

With typo fixed:

Reviewed-by: Denis Mukhin <dmukhin@ford.com> 


> +	HOST_FLAG_BROKEN		= BIT(0),
>  };
>  
>  /**
> -- 
> 2.53.0
> 

      reply	other threads:[~2026-07-27 17:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 17:00 [PATCH 1/1] sandbox: fix enum host_platform_flags description Heinrich Schuchardt via U-Boot
2026-07-27 17:29 ` Denis Mukhin via U-Boot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ameVXBb54ICYdIl3@kraken \
    --to=u-boot@lists.u-boot-project.org \
    --cc=dmukhin@ford.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox