From: Yao Zi <me@ziyao.cc>
To: Eric Chung <eric.chung@riscstar.com>,
u-boot-spacemit@groups.io, u-boot@lists.u-boot-project.org
Cc: Tom Rini <trini@konsulko.com>, Tim Ouyang <tim609@andestech.com>,
Leo Liang <leo.liang@sifive.com>, Peng Fan <peng.fan@nxp.com>,
Huan Zhou <pericycle.cc@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>,
Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
Kaustabh Chakraborty <kauschluss@disroot.org>,
Han Xu <han.xu@nxp.com>, Yanir Levin <yanir.levin@tandemg.com>,
Christoph Stoidner <c.stoidner@phytec.de>,
Balsundar Ponnusamy <balsundar.ponnusamy@altera.com>,
Daniel Palmer <daniel@thingy.jp>, Anshul Dalal <anshuld@ti.com>,
Bastien Curutchet <bastien.curutchet@bootlin.com>,
Angelo Dureghello <angelo@kernel-space.org>,
Johan Jonker <jbx6244@gmail.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Guodong Xu <guodong@riscstar.com>, Yao Zi <me@ziyao.cc>,
Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>
Subject: Re: [PATCH v6 11/11] spacemit: k1: load product name from environment variable
Date: Mon, 27 Jul 2026 17:41:29 +0000 [thread overview]
Message-ID: <ameYSWjELnlovONB@pie> (raw)
In-Reply-To: <20260727-m4-v6-11-2f58566d48ca@riscstar.com>
On Mon, Jul 27, 2026 at 02:59:13PM +0800, Eric Chung wrote:
> Read the product name from the environment instead of EEPROM,
> as the EEPROM may not be programmed and the environment always
> contains this information.
Please explain why the environment "always contains this information".
This sounds strange since the environment variable is placed on MMC,
and there should be no "product_name" environment variable in the
environment partition if U-Boot is flashed to a completely new and
empty MMC.
The EEPROM should be the most robost way to distinguish board types. If
you do have devices with unprogrammed EEPROMs, please provide a guide to
program it correctly.
Furthremore, this doesn't seem to fit the subject of the series,
"spacemit mmc driver", since I don't think these changes are required
for MMC to work. So I think this patch should be split out even if you
do want to change the board detection logic.
> Signed-off-by: Eric Chung <eric.chung@riscstar.com>
Best regards,
Yao Zi
prev parent reply other threads:[~2026-07-27 17:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 6:59 [PATCH v6 00/11] spacemit mmc driver Eric Chung
2026-07-27 6:59 ` [PATCH v6 01/11] spacemit: k1: select boot device via config registers Eric Chung
2026-07-27 6:59 ` [PATCH v6 02/11] pinctrl: k1: fix drive strength configuration Eric Chung
2026-07-27 6:59 ` [PATCH v6 03/11] pinctrl: k1: fix pull-up/pull-down configuration Eric Chung
2026-07-27 8:20 ` Yao Zi
2026-07-27 8:24 ` Yao Zi
2026-07-27 6:59 ` [PATCH v6 04/11] pinctrl: k1: add IO power domain configuration support Eric Chung
2026-07-28 17:15 ` Junhui Liu
2026-07-27 6:59 ` [PATCH v6 05/11] mmc: k1: add sdhci platform driver Eric Chung
2026-07-27 6:59 ` [PATCH v6 06/11] dts: k1: add SD card support in u-boot overlay Eric Chung
2026-07-27 11:51 ` Yao Zi
2026-07-27 13:08 ` Eric Chung
2026-07-27 17:07 ` Yao Zi
2026-07-28 1:04 ` Eric Chung
2026-07-28 9:10 ` Yao Zi
2026-07-29 14:05 ` Eric Chung
2026-07-29 15:58 ` Yao Zi
2026-07-30 5:18 ` Eric Chung
2026-07-27 6:59 ` [PATCH v6 07/11] configs: k1: enable SD and eMMC support Eric Chung
2026-07-27 17:15 ` Yao Zi
2026-07-27 6:59 ` [PATCH v6 08/11] MAINTAINER: update Spacemit K1 entry Eric Chung
2026-07-27 6:59 ` [PATCH v6 09/11] doc: spacemit: flash on K1 SoC based boards Eric Chung
2026-07-27 17:26 ` Yao Zi
2026-07-28 0:53 ` Eric Chung
2026-07-28 9:45 ` Yao Zi
2026-07-29 13:49 ` Eric Chung
2026-07-29 15:32 ` Yao Zi
2026-07-30 6:25 ` Eric Chung
2026-07-30 15:20 ` Yao Zi
2026-07-31 0:31 ` Eric Chung
2026-07-27 6:59 ` [PATCH v6 10/11] config: k1: enable ENV support for eMMC Eric Chung
2026-07-27 6:59 ` [PATCH v6 11/11] spacemit: k1: load product name from environment variable Eric Chung
2026-07-27 17:41 ` Yao Zi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ameYSWjELnlovONB@pie \
--to=me@ziyao.cc \
--cc=angelo@kernel-space.org \
--cc=anshuld@ti.com \
--cc=balsundar.ponnusamy@altera.com \
--cc=bastien.curutchet@bootlin.com \
--cc=bhimeswararao.matsa@gmail.com \
--cc=c.stoidner@phytec.de \
--cc=daniel@thingy.jp \
--cc=eric.chung@riscstar.com \
--cc=guodong@riscstar.com \
--cc=han.xu@nxp.com \
--cc=jbx6244@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=kauschluss@disroot.org \
--cc=leo.liang@sifive.com \
--cc=peng.fan@nxp.com \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=rick@andestech.com \
--cc=semen.protsenko@linaro.org \
--cc=tanmay.kathpalia@altera.com \
--cc=tim609@andestech.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
--cc=yanir.levin@tandemg.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox