From: Ralph Siemsen <ralph.siemsen@linaro.org>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: u-boot@lists.u-boot-project.org, Tom Rini <trini@konsulko.com>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Udit Kumar <u-kumar1@ti.com>
Subject: Re: [PATCH v2 4/8] ARM: renesas: RZ/N1 QSPI controller features
Date: Fri, 28 Aug 2026 13:53:01 -0400 [thread overview]
Message-ID: <apHK_Q-dogLc3Mkr@maple.netwinder.org> (raw)
In-Reply-To: <7243d0c9-1466-4236-9d41-5d78fa1cae4f@mailbox.org>
On Sat, Aug 15, 2026 at 12:25:10AM +0200, Marek Vasut wrote:
>On 8/14/26 8:38 PM, Ralph Siemsen wrote:
>>
>>diff --git a/arch/arm/mach-renesas/Kconfig b/arch/arm/mach-renesas/Kconfig
>>index f86acc31039..4d16d541443 100644
>>--- a/arch/arm/mach-renesas/Kconfig
>>+++ b/arch/arm/mach-renesas/Kconfig
>>@@ -70,9 +70,13 @@ config RZN1
>> select DM
>> select DM_ETH
>> select DM_SERIAL
>>+ select DM_SPI
>> select PINCTRL
>> select PINCONF
>> select REGMAP
>>+ select SPI
>
>Shouldn't this be in board config ? Not all RZN1 boards likely require SPI ?
Any RZ/N1 board that makes use of the QSPI will want this. It could be
done in the defconfig, but it is easy to miss, and not fun to debug
(took many hours of printf() for me to find it)
>>+ select SPI_MEM
>>+ select SPI_DIRMAP
>Shouldn't this be selected by the SPI NOR driver instead ?
The same driver has other users, but they may not all want DIRMAP.
I will move these settings under TARGET_SCHNEIDER_RZN1 so they are
specific to this board.
Ralph
next prev parent reply other threads:[~2026-08-28 17:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 18:38 [PATCH v2 0/8] Renesas RZ/N1 additional drivers Ralph Siemsen
2026-08-14 18:38 ` [PATCH v2 1/8] board: schneider: rzn1-snarc: set serial number Ralph Siemsen
2026-08-14 22:22 ` Marek Vasut via U-Boot
2026-08-14 18:38 ` [PATCH v2 2/8] board: schneider: rzn1-snarc: add rzn1.env Ralph Siemsen
2026-08-14 22:23 ` Marek Vasut via U-Boot
2026-08-14 18:38 ` [PATCH v2 3/8] board: schneider: rzn1-snarc: update MAINTAINERS Ralph Siemsen
2026-08-14 22:24 ` Marek Vasut via U-Boot
2026-08-14 18:38 ` [PATCH v2 4/8] ARM: renesas: RZ/N1 QSPI controller features Ralph Siemsen
2026-08-14 22:25 ` Marek Vasut via U-Boot
2026-08-28 17:53 ` Ralph Siemsen [this message]
2026-08-28 21:18 ` Marek Vasut
2026-08-14 18:38 ` [PATCH v2 5/8] ARM: dts: r9a06g032: sync with upstream Ralph Siemsen
2026-08-14 22:26 ` Marek Vasut via U-Boot
2026-08-15 12:24 ` Ralph Siemsen
2026-08-16 11:25 ` Marek Vasut via U-Boot
2026-08-28 17:54 ` Ralph Siemsen
2026-08-28 18:27 ` Marek Vasut
2026-08-14 18:38 ` [PATCH v2 6/8] ARM: dts: r9a06g032: add QSPI controller Ralph Siemsen
2026-08-14 18:38 ` [PATCH v2 7/8] ARM: dts: r9a06g032-rzn1-snarc: enable new drivers Ralph Siemsen
2026-08-14 18:39 ` [PATCH v2 8/8] configs: rzn1_snarc_defconfig: " Ralph Siemsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apHK_Q-dogLc3Mkr@maple.netwinder.org \
--to=ralph.siemsen@linaro.org \
--cc=ilias.apalodimas@linaro.org \
--cc=iwamatsu@nigauri.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=marek.vasut@mailbox.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox