From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: "Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
"Mattijs Korpershoek" <mkorpershoek@kernel.org>,
"Tejas Narendra Joglekar" <Tejas.Joglekar@synopsys.com>,
"u-boot@lists.u-boot-project.org"
<u-boot@lists.u-boot-project.org>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Tom Rini" <trini@konsulko.com>,
"Łukasz Majewski" <lukma@nabladev.com>,
"Dan Tran" <Dan.Tran1@synopsys.com>
Subject: Re: [PATCH v3 1/2] usb: gadget: mass_storage: add SuperSpeed descriptor support
Date: Wed, 9 Sep 2026 01:58:34 +0000 [thread overview]
Message-ID: <aqC8hnAHrQ8Cv3iR@vbox> (raw)
In-Reply-To: <8d741110-05eb-4861-94b9-19ef27c9ce2b@mailbox.org>
On Fri, Sep 04, 2026, Marek Vasut wrote:
> On 9/4/26 4:29 AM, Thinh Nguyen wrote:
>
> Hello Thinh,
>
> > @@ -2709,6 +2712,27 @@ static int fsg_bind(struct usb_configuration *c, struct usb_function *f)
> > return -ENOMEM;
> > }
> > }
> > +
> > + if (gadget_is_superspeed(gadget)) {
>
> Nitpick -- you could invert the conditional here and reduce indent:
>
> if (!gadget_is_superspeed(gadget))
> return 0;
>
> ...
>
But wouldn't that deviate further from the original Linux
change? See:
4bb99b7c82ba ("usb: gadget: storage: add superspeed support")
BR,
Thinh
next prev parent reply other threads:[~2026-09-09 5:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 2:29 [PATCH v3 0/2] usb: gadget: add SuperSpeed descriptor support Thinh Nguyen
2026-09-04 2:29 ` [PATCH v3 1/2] usb: gadget: mass_storage: " Thinh Nguyen
2026-09-04 2:43 ` Marek Vasut
2026-09-09 1:58 ` Thinh Nguyen [this message]
2026-09-09 2:20 ` Marek Vasut
2026-09-09 9:08 ` Mattijs Korpershoek
2026-09-09 13:25 ` Marek Vasut
2026-09-09 9:10 ` Mattijs Korpershoek
2026-09-04 2:29 ` [PATCH v3 2/2] usb: gadget: dfu: " Thinh Nguyen
2026-09-09 9:10 ` Mattijs Korpershoek
2026-09-11 9:25 ` [PATCH v3 0/2] usb: gadget: " Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqC8hnAHrQ8Cv3iR@vbox \
--to=thinh.nguyen@synopsys.com \
--cc=Dan.Tran1@synopsys.com \
--cc=Tejas.Joglekar@synopsys.com \
--cc=lukma@nabladev.com \
--cc=marek.vasut@mailbox.org \
--cc=mkorpershoek@kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox