From: Yao Zi <me@ziyao.cc>
To: Nikita Shubin <nikita.shubin@maquefel.me>,
u-boot@lists.u-boot-project.org
Cc: Yao Zi <me@ziyao.cc>, Tom Rini <trini@konsulko.com>,
Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH v5 0/2] riscv: timer: Fix M-mode early timer support
Date: Sun, 13 Sep 2026 18:48:28 +0000 [thread overview]
Message-ID: <aqbv_KSwVDmn3z46@pie> (raw)
In-Reply-To: <20260911-riscv_fix_early_timer_mmode-v5-0-98e7aaf91396@maquefel.me>
On Fri, Sep 11, 2026 at 04:35:22PM +0300, Nikita Shubin wrote:
> This series addresses two issues with the generic RISC-V timer driver.
>
> Patch 1 marks timer_early_get_rate() and timer_early_get_count() as __weak
> to prevent link conflicts with other drivers (e.g., ACLINT MTIMER) that may
> also provide their own implementation.
>
> Patch 2 adds proper M‑mode support: timer_early_get_rate() is now defined
> for M‑mode using RISCV_MMODE_TIMER_FREQ, and timer_early_get_count() is
> no longer guarded by RISCV_SMODE, making it available whenever
> CONFIG_TIMER_EARLY is enabled. This is necessary because functions like
> net_random_ethaddr() rely on get_ticks() which uses timer_early_get_count().
For the whole series,
Reviewed-by: Yao Zi <me@ziyao.cc>
Thanks for your work!
Regards,
Yao Zi
> ---
> Nikita Shubin (2):
> riscv: timer: Make RISCV_TIMER definitions weak
> riscv: timer: Enable early timer for M‑mode
>
> drivers/timer/Kconfig | 9 +++++++--
> drivers/timer/riscv_timer.c | 16 +++++++++++-----
> 2 files changed, 18 insertions(+), 7 deletions(-)
> ---
> base-commit: cc557af4553382f6f50e3ed62b9577054e7bc54f
> change-id: 20260904-riscv_fix_early_timer_mmode-174f3ee4e106
>
> Best regards,
> --
> Nikita Shubin
>
prev parent reply other threads:[~2026-09-13 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 13:35 [PATCH v5 0/2] riscv: timer: Fix M-mode early timer support Nikita Shubin
2026-09-11 13:35 ` [PATCH v5 1/2] riscv: timer: Make RISCV_TIMER definitions weak Nikita Shubin
2026-09-11 13:35 ` [PATCH v5 2/2] riscv: timer: Enable early timer for M‑mode Nikita Shubin
2026-09-13 18:48 ` Yao Zi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqbv_KSwVDmn3z46@pie \
--to=me@ziyao.cc \
--cc=michal.simek@amd.com \
--cc=nikita.shubin@maquefel.me \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).