U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Carlo Caione <ccaione@baylibre.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.u-boot-project.org,
	uboot-stm32@st-md-mailman.stormreply.com,
	"Peng Fan" <peng.fan@nxp.com>,
	"Jaehoon Chung" <jh80.chung@samsung.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Bastien Curutchet" <bastien.curutchet@bootlin.com>,
	"Alexey Charkov" <alchark@gmail.com>,
	"Johan Jonker" <jbx6244@gmail.com>,
	"Richard Genoud" <richard.genoud@bootlin.com>,
	"João Marcos Costa" <joaomarcos.costa@bootlin.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Julien Stephan" <jstephan@baylibre.com>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>
Subject: Re: [PATCH v3 1/2] spl: mmc: select the boot partition after device initialization
Date: Mon, 14 Sep 2026 22:56:49 +0200	[thread overview]
Message-ID: <aqhe4KnMjO2HQiDA@macbook> (raw)
In-Reply-To: <20260914163557.GA1764417@bill-the-cat>

On Mon, Sep 14, 2026 at 10:35:57 +0100, Tom Rini wrote:
> On Mon, Sep 14, 2026 at 10:31:37AM +0200, Carlo Caione wrote:

[...]  
> > -struct mmc;
> 
> Have you thrown this through CI? We have that forward declaration
> because it's not otherwise defined, and we wanted to avoid pulling in a
> big header chain here to declare it. So I worry something is going to
> fail to build now.

Hi Tom,
yes, the CI is all green. include/spl.h already includes <mmc.h>
unconditionally so struct mmc is defined before these prototypes.

Thanks,

--
Carlo Caione

  reply	other threads:[~2026-09-14 20:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  8:31 [PATCH v3 0/2] Support board-selected raw partitions Carlo Caione
2026-09-14  8:31 ` [PATCH v3 1/2] spl: mmc: select the boot partition after device initialization Carlo Caione
2026-09-14 16:35   ` Tom Rini
2026-09-14 20:56     ` Carlo Caione [this message]
2026-09-14 21:33       ` Tom Rini
2026-09-21 20:05         ` Carlo Caione
2026-09-21 20:32           ` Tom Rini
2026-09-14  8:31 ` [PATCH v3 2/2] spl: mmc: make raw partition selection a choice Carlo Caione
2026-09-14 16:40   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqhe4KnMjO2HQiDA@macbook \
    --to=ccaione@baylibre.com \
    --cc=alchark@gmail.com \
    --cc=bastien.curutchet@bootlin.com \
    --cc=dlechner@baylibre.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jbx6244@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=joaomarcos.costa@bootlin.com \
    --cc=jstephan@baylibre.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=neil.armstrong@linaro.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=peng.fan@nxp.com \
    --cc=richard.genoud@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox