U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hiago De Franco <hfranco@baylibre.com>
To: Zhuxu Ran <zhuxu_ran@zohomail.com>
Cc: u-boot@lists.u-boot-project.org, Yao Zi <me@ziyao.cc>,
	 Tom Rini <trini@konsulko.com>, Johan Jonker <jbx6244@gmail.com>,
	 Alexander Koch <akoch@initse.com>,
	Kongyang Liu <seashell11234455@gmail.com>,
	 Thomas Bonnefille <thomas.bonnefille@bootlin.com>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	 Peter Robinson <pbrobinson@gmail.com>,
	Leo Yu-Chi Liang <leo.liang@sifive.com>,
	Casey Connolly <casey.connolly@linaro.org>,
	Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
	 Sumit Garg <sumit.garg@oss.qualcomm.com>,
	Heiko Stuebner <heiko@sntech.de>,
	 Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Marek Vasut <marex@nabladev.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH v3 0/3] rtc: cv1800b: Use the RTC node for time and system reset
Date: Wed, 7 Oct 2026 09:16:57 -0300	[thread overview]
Message-ID: <asY4AesoD7a9doj9@hiagonb> (raw)
In-Reply-To: <20261007-cv18xx-rtc-sysreset-v3-0-194557fd5e78@zohomail.com>

On Wed, Oct 07, 2026 at 11:33:04AM +0800, Zhuxu Ran wrote:
> The CV1800B RTC subsystem contains a seconds counter and system reset
> controls in a shared register range. U-Boot currently binds the system
> reset driver from Milk-V Duo board code and accesses fixed MMIO addresses.
> The upstream devicetrees describe this subsystem with an RTC node, but
> U-Boot has no driver matching that node.
> 
> Add an RTC driver for the seconds counter, bind the existing system reset
> driver as its child, and obtain the reset register range from the shared
> devicetree node. Keep the existing reset requests unchanged, including
> the warm-reset sequence currently used for SYSRESET_COLD.
> 
> This series depends on the CV18xx upstream-devicetree conversion sent
> as v5.
> 
> Tested on Milk-V Duo, Milk-V Duo 256M and LicheeRV Nano.
> 
> Signed-off-by: Zhuxu Ran <zhuxu_ran@zohomail.com>

Thanks for the patches. For the series:

Reviewed-by: Hiago De Franco <hfranco@baylibre.com>

> ---
> Changes in v3:
> - Rename the RTC driver file to cv1800b.c to match the RTC directory
>   convention.
> - Align the CV1800B sysreset register and request-bit definitions.
> - Use uppercase hexadecimal digits in the sysreset driver.
> - Link to v2: https://patch.msgid.link/20261006-cv18xx-rtc-sysreset-v2-0-67872888384e@zohomail.com
> 
> Changes in v2:
> - Use CV1800B consistently in the RTC driver filename and identifiers.
> - Link to v1: https://patch.msgid.link/20261003-cv18xx-rtc-sysreset-v1-0-c0837e26eb29@zohomail.com
> 
> ---
> Zhuxu Ran (3):
>       rtc: cv1800b: Add seconds counter support
>       riscv: sophgo: Enable RTC-backed system reset
>       sysreset: cv1800b: Use the RTC device node for register access
> 
>  board/sophgo/milkv_duo/board.c         |   5 --
>  configs/milkv_duo_256m_defconfig       |   2 +
>  configs/milkv_duo_defconfig            |   2 +
>  configs/sipeed_licheerv_nano_defconfig |   2 +
>  drivers/rtc/Kconfig                    |   9 +++
>  drivers/rtc/Makefile                   |   1 +
>  drivers/rtc/cv1800b.c                  | 123 +++++++++++++++++++++++++++++++++
>  drivers/sysreset/Kconfig               |   6 +-
>  drivers/sysreset/sysreset_cv1800b.c    |  90 +++++++++++++++---------
>  9 files changed, 199 insertions(+), 41 deletions(-)
> ---
> base-commit: a06e89ab05eaa2b8344d521319399333cd760ae5
> change-id: 20260929-cv18xx-rtc-sysreset-b816e6306348
> prerequisite-message-id: <20260927-milkv-duo-upstream-dts-v5-0-7f64983e59e1@zohomail.com>
> prerequisite-patch-id: b8e6815314b7881a02de0066232864d522c4a26c
> prerequisite-patch-id: 0df1fa5db1b2bff402b429809796bad99a517483
> prerequisite-patch-id: 49e1e8263cf0a5ba8d63c8b598b6382cde5284b2
> prerequisite-patch-id: 86dd30e784f022f0a7bb6fbf125c9699467176d4
> prerequisite-patch-id: 49070c05ecf58331ec519a57d1b82f8b2b835a89
> prerequisite-patch-id: 6b6881e45cc6de6544aaa4509db21611158f4fa1
> prerequisite-patch-id: 7198127d4602eeb14212087ce9bb694d84e71a4c
> prerequisite-patch-id: 3a58bd8a061707ff27b8538d4897def3b595dc36
> prerequisite-patch-id: 9055ea941b73e35d1e825787d7eca14ffceb8e8b
> prerequisite-patch-id: 554c1487e8d596e0099677ca88eee0021b1ffbae
> 
> Best regards,
> --  
> Zhuxu Ran <zhuxu_ran@zohomail.com>
> 

Best regards,
-- 
Hiago

      parent reply	other threads:[~2026-10-07 12:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  3:33 [PATCH v3 0/3] rtc: cv1800b: Use the RTC node for time and system reset Zhuxu Ran
2026-10-07  3:33 ` [PATCH v3 1/3] rtc: cv1800b: Add seconds counter support Zhuxu Ran
2026-10-07 22:24   ` Yao Zi
2026-10-07  3:33 ` [PATCH v3 2/3] riscv: sophgo: Enable RTC-backed system reset Zhuxu Ran
2026-10-07  3:33 ` [PATCH v3 3/3] sysreset: cv1800b: Use the RTC device node for register access Zhuxu Ran
2026-10-07 12:16 ` Hiago De Franco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asY4AesoD7a9doj9@hiagonb \
    --to=hfranco@baylibre.com \
    --cc=akoch@initse.com \
    --cc=casey.connolly@linaro.org \
    --cc=heiko@sntech.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jbx6244@gmail.com \
    --cc=leo.liang@sifive.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=marex@nabladev.com \
    --cc=me@ziyao.cc \
    --cc=pbrobinson@gmail.com \
    --cc=quentin.schulz@cherry.de \
    --cc=seashell11234455@gmail.com \
    --cc=sumit.garg@oss.qualcomm.com \
    --cc=thomas.bonnefille@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=varadarajan.narayanan@oss.qualcomm.com \
    --cc=zhuxu_ran@zohomail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox