From: Yao Zi <me@ziyao.cc>
To: Hiago De Franco <hfranco@baylibre.com>,
Leo Yu-Chi Liang <leo.liang@sifive.com>,
u-boot@lists.u-boot-project.org, Yao Zi <me@ziyao.cc>
Cc: Tom Rini <trini@konsulko.com>, Tim Ouyang <tim609@andestech.com>,
Zhuxu Ran <zhuxu_ran@zohomail.com>,
Kongyang Liu <seashell11234455@gmail.com>
Subject: Re: [PATCH v2] board: sophgo: milkv_duo_256m: fix fdtfile quoting
Date: Sat, 10 Oct 2026 07:52:51 +0000 [thread overview]
Message-ID: <asnu01a12_v8TK5_@pie> (raw)
In-Reply-To: <20261009-256m-fixes-v2-1-33405d040636@baylibre.com>
On Fri, Oct 09, 2026 at 11:38:23AM -0300, Hiago De Franco wrote:
> CONFIG_DEFAULT_DEVICE_TREE is a quoted string, so the quotes end up in
> the environment:
>
> fdtfile="sg2002-milkv-duo256m".dtb
>
> Use DEFAULT_DEVICE_TREE instead, which the build passes to the
> environment preprocessor without the quotes:
>
> fdtfile=sophgo/sg2002-milkv-duo256m.dtb
>
> Fixes: 98b59e181daa ("board: sophgo: add support for Milk-V Duo 256M")
> Signed-off-by: Hiago De Franco <hfranco@baylibre.com>
> ---
> This is a continuation of
> https://lore.kernel.org/all/20260930-256m-fixes-v1-0-69546876ff28@baylibre.com/,
> as asked by Yao Zi.
>
> Tested on the Milk-V Duo 256M (SG2002).
Reviewed-by: Yao Zi <me@ziyao.cc>
Regards,
Yao Zi
prev parent reply other threads:[~2026-10-10 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 14:38 [PATCH v2] board: sophgo: milkv_duo_256m: fix fdtfile quoting Hiago De Franco
2026-10-10 7:52 ` Yao Zi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asnu01a12_v8TK5_@pie \
--to=me@ziyao.cc \
--cc=hfranco@baylibre.com \
--cc=leo.liang@sifive.com \
--cc=seashell11234455@gmail.com \
--cc=tim609@andestech.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=zhuxu_ran@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox