U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@kernel.org>
To: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
Cc: Sumit Garg <sumit.garg@kernel.org>,
	u-boot@lists.u-boot-project.org, u-boot-qcom@groups.io,
	Lukasz Majewski <lukma@denx.de>, Tom Rini <trini@konsulko.com>,
	Casey Connolly <casey.connolly@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Johan Jonker <jbx6244@gmail.com>,
	Luca Weiss <luca.weiss@fairphone.com>,
	Biswapriyo Nath <nathbappai@gmail.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH v2 6/7] arm64: dts: monaco-evk: Force vreg_l8a always-on to protect UFS VCC
Date: Mon, 19 Oct 2026 17:31:28 +0530	[thread overview]
Message-ID: <atYGmDLyFKdDCZwZ@sumit-xelite> (raw)
In-Reply-To: <20260812-b4-monaco-v2-6-865d288c0be6@oss.qualcomm.com>

On Wed, 12 Aug 2026 at 06:42:04 +0530, Balaji Selvanathan wrote:
>vreg_l8a is the shared VCC rail for UFS (ufs_mem_hc vcc-supply) and
>eMMC (sdhc_1 vmmc-supply). UFS holds no regulator vote of its own in
>U-Boot, so nothing stops other consumers from disabling the rail
>while UFS still needs it.

Why not teach UFS driver to keep it's regulator vote intact? Don't add
DT workarounds for this.

-Sumit

>
>eMMC's power-cycle runs after UFS has already linked up and started
>transferring data. Its power-off fires a real disable vote on
>vreg_l8a, glitching UFS VCC while the link is live. UFS has no
>recovery from this: every following command fails (OCS errors, UTP
>timeouts, "Card did not respond to voltage select! : -110").
>
>Force the rail always-on so the disable vote is rejected in
>regulator_set_enable() (-EACCES) before it reaches the RPMh driver.
>eMMC is non-removable and does not need a real power-cycle.
>
>Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
>---
> arch/arm/dts/monaco-evk-u-boot.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/arch/arm/dts/monaco-evk-u-boot.dtsi b/arch/arm/dts/monaco-evk-u-boot.dtsi
>index 5520d111864..8e9102eae4d 100644
>--- a/arch/arm/dts/monaco-evk-u-boot.dtsi
>+++ b/arch/arm/dts/monaco-evk-u-boot.dtsi
>@@ -34,3 +34,7 @@
> 		};
> 	};
> };
>+
>+&vreg_l8a {
>+	regulator-always-on;
>+};
>
>-- 
>2.34.1
>

  reply	other threads:[~2026-10-19 12:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  1:11 [PATCH v2 0/7] qcom: qcs8300/monaco-evk: pinctrl, interconnect, RPMH clock and reboot-mode support Balaji Selvanathan via U-Boot
2026-08-12  1:11 ` [PATCH v2 1/7] clk: qcom: Add shared RPMH clock driver for SM8550/SM8650/SA8775P Balaji Selvanathan via U-Boot
2026-08-12 12:26   ` Neil Armstrong
2026-08-12  1:12 ` [PATCH v2 2/7] clk: qcom: qcs8300: Extend GCC clock driver to full gate/RCG coverage Balaji Selvanathan via U-Boot
2026-10-19 11:54   ` Sumit Garg
2026-08-12  1:12 ` [PATCH v2 3/7] pinctrl: qcom: Add QCS8300 pinctrl driver Balaji Selvanathan via U-Boot
2026-10-19 11:56   ` Sumit Garg
2026-08-12  1:12 ` [PATCH v2 4/7] interconnect: qcom: Add QCS8300 interconnect driver Balaji Selvanathan via U-Boot
2026-08-12  1:12 ` [PATCH v2 5/7] arm64: dts: monaco-evk: Add reboot-mode support via PON/SDAM Balaji Selvanathan via U-Boot
2026-10-19 11:58   ` Sumit Garg
2026-08-12  1:12 ` [PATCH v2 6/7] arm64: dts: monaco-evk: Force vreg_l8a always-on to protect UFS VCC Balaji Selvanathan via U-Boot
2026-10-19 12:01   ` Sumit Garg [this message]
2026-08-12  1:12 ` [PATCH v2 7/7] configs: qcom_qcs8300: Switch to monaco-evk DT and enable new drivers Balaji Selvanathan via U-Boot
2026-10-19 12:03   ` Sumit Garg
2026-10-08 12:44 ` [PATCH v2 0/7] qcom: qcs8300/monaco-evk: pinctrl, interconnect, RPMH clock and reboot-mode support Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atYGmDLyFKdDCZwZ@sumit-xelite \
    --to=sumit.garg@kernel.org \
    --cc=balaji.selvanathan@oss.qualcomm.com \
    --cc=casey.connolly@linaro.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jbx6244@gmail.com \
    --cc=luca.weiss@fairphone.com \
    --cc=lukma@denx.de \
    --cc=nathbappai@gmail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox