U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ralph Siemsen <ralph.siemsen@linaro.org>
To: Quentin Schulz <quentin.schulz@cherry.de>
Cc: u-boot@lists.u-boot-project.org, Tom Rini <trini@konsulko.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	E Shattow <e@freeshell.de>
Subject: Re: [PATCH v2] doc: develop/sending_patches: add tips for series
Date: Fri, 6 Nov 2026 13:41:02 -0500	[thread overview]
Message-ID: <au4fPht4wT72RFUD@maple.netwinder.org> (raw)
In-Reply-To: <fc54cf9e-e56f-427b-b390-fbb2c9ea5c1c@cherry.de>

On Thu, Nov 05, 2026 at 04:46:17PM +0100, Quentin Schulz wrote:
>Hi Ralph,
>
>On 11/5/26 3:33 PM, Ralph Siemsen wrote:
>>I also agree that it is hard to detect the actual dependencies. And in 
>>fact they are not static: when a reviewer of one series requests 
>>changes, it can often impact other series. Which suggests that there 
>>is a dependency, even if it was not apparent initially.
>>
>
>At some point, there's also "don't send too many series at once". If 
>your series A requires big changes in series B, it either means it 
>should be series A+B, or that series B was sent too early and we 
>should focus on answering design questions in series A before having a 
>look at series B. Sometimes patience pays off in the long run.

When adding a new SoC, we end up with series A+B and often many more. 
All of that code needs to be written in order to get the device to boot, 
so it is generally not possible to "upstream" any of it until it's all 
functional. (I don't like to send out untested code!)

The problem then becomes, which series to send first. Inevitably, in at 
least one of the series, a reviewer will suggest another approach, 
perhaps to extend some existing subsystem, or simply to do certain 
things a different way.

Unfortunately such suggestions frequently result in changes to the other 
series. These changes are hard to anticipate or plan for. Sometimes I 
try to send an early preview "RFC" to help identify such issues. But 
even then, during the actual merge, further changes are requested, once 
again with ripple effects on other series.

Sending out the series in a different order would not avoid this problem 
in general. Specifically because it is hard to know which parts will 
generate friction with reviewers. My guesses have been wrong more often 
than not in this regard.

Not sure there is anything we can really do about it, but I can totally 
understand why someone would send large "add new SoC xyz" patch series. 
It keeps everything together and the ripple effect of one change can be 
seen more clearly, than if all the pieces were done in separate series 
over a longer time period, with goalposts being moved along the way.

Anyhow, I've posted v3, with a focus on making it easier for the 
reviewers and the future code maintainer.

Regards,
Ralph

  reply	other threads:[~2026-11-06 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 19:48 [PATCH v2] doc: develop/sending_patches: add tips for series Ralph Siemsen
2026-11-05 11:00 ` Quentin Schulz
2026-11-05 14:33   ` Ralph Siemsen
2026-11-05 15:46     ` Quentin Schulz
2026-11-06 18:41       ` Ralph Siemsen [this message]
2026-11-12 15:48         ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=au4fPht4wT72RFUD@maple.netwinder.org \
    --to=ralph.siemsen@linaro.org \
    --cc=e@freeshell.de \
    --cc=neil.armstrong@linaro.org \
    --cc=quentin.schulz@cherry.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox