Re: [PATCH v6 06/20] LoongArch: skeleton and headers

[Yao Zi <me@ziyao.cc>]

On Sat, Oct 31, 2026 at 01:42:37AM -0700, Simon Glass wrote:
> Hi Jiaxun,
> 
> On 2026-10-29T05:07:18+11:00, Yao Zi <me@ziyao.cc> wrote:
> > LoongArch: skeleton and headers
> >
> > Commit for directories, Kconfig, Makefile and headers, aiming to build
> > for 64-bit LoongArch hardware with FPU.
> >
> > Some of them are copied from linux, some of them are derived
> > from other architectures, the rest are written on my own.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Signed-off-by: Yao Zi <me@ziyao.cc>
> 
> > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> > @@ -0,0 +1,40 @@
> > +choice
> > +	prompt "Target select"
> > +
> > +endchoice
> 
> Please can you move this empty choice into the qemu-loongarch patch,
> which adds the first entry (TARGET_QEMU_LOONGARCH_VIRT)? Until then it
> is just an empty menu.

This is a "skeleton" commit, so I think it's natural to introduce the
menu here, and fill things into the "skeleton" later. But either is fine
with me.

> In any case:
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Regards,
> Simon

Regards,
Yao Zi