U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Carlo Caione <ccaione@baylibre.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Tom Rini <trini@konsulko.com>,
	 Alper Nebi Yasak <alpernebiyasak@gmail.com>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Weijie Gao <weijie.gao@mediatek.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Igor Belwon <igor.belwon@mentallysanemainliners.org>,
	Julien Stephan <jstephan@baylibre.com>,
	 GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
	Macpaul Lin <Macpaul.Lin@mediatek.com>,
	 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	u-boot@lists.u-boot-project.org,
	Michal Simek <michal.simek@amd.com>,
	Casey Connolly <casey.connolly@linaro.org>
Subject: Re: [PATCH 01/10] binman: allow a control devicetree separate from the image description
Date: Thu, 12 Nov 2026 23:09:46 +0100	[thread overview]
Message-ID: <avY3RL80pHsZoiFO@macbook> (raw)
In-Reply-To: <20261112-mtk-genio-binman-dtb-v1-1-65cfc9329c50@baylibre.com>

On Thu, Nov 12, 2026 at 15:14:56 +0100, David Lechner wrote:
> Add a --u-boot-dtb option to 'binman build' that gives the U-Boot
> control devicetree to use for u-boot-dtb entries, including the ones in
> expanded u-boot entries.

Hi David,

I think you should take care also of 'binman replace' when using the new
separate control devicetree support.

PrepareFromLoadedData() still assumes that each embedded DTB contains a
/binman node:

  image_node = dtb.GetNode('/binman')
  if 'multiple-images' in image_node.props:

With --u-boot-dtb, the control DTB no longer contains that node, so
replacement fails with:

  AttributeError: 'NoneType' object has no attribute 'props'

Besides that this is a cool work.

Thanks,

--
Carlo Caione

  reply	other threads:[~2026-11-12 22:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 21:14 [PATCH 00/10] binman: support separate binman devicetree from control devicetree David Lechner
2026-11-12 21:14 ` [PATCH 01/10] binman: allow a control devicetree separate from the image description David Lechner
2026-11-12 22:09   ` Carlo Caione [this message]
2026-11-12 21:14 ` [PATCH 02/10] Makefile: give binman the control devicetree with BINMAN_DTB David Lechner
2026-11-12 21:14 ` [PATCH 03/10] binman: support building binman dtb when OF_UPSTREAM is enabled David Lechner
2026-11-12 21:14 ` [PATCH 04/10] dts: always build the binman devicetree from BINMAN_DTB David Lechner
2026-11-12 21:15 ` [PATCH 05/10] lib: Kconfig: do not enable BINMAN_FDT by default with BINMAN_DTB David Lechner
2026-11-12 21:15 ` [PATCH 06/10] binman: recommend a separate devicetree for the image description David Lechner
2026-11-12 21:15 ` [PATCH 07/10] arm: dts: mediatek: drop the -u-boot suffix from the Genio binman files David Lechner
2026-11-12 21:15 ` [PATCH 08/10] arm: mediatek: describe the Genio images in a separate binman devicetree David Lechner
2026-11-12 21:15 ` [PATCH 09/10] board: mediatek: add a Genio boot images config fragment David Lechner
2026-11-12 21:15 ` [PATCH 10/10] doc: board: mediatek: use the " David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avY3RL80pHsZoiFO@macbook \
    --to=ccaione@baylibre.com \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=Macpaul.Lin@mediatek.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=casey.connolly@linaro.org \
    --cc=chunfeng.yun@mediatek.com \
    --cc=dlechner@baylibre.com \
    --cc=igor.belwon@mentallysanemainliners.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jstephan@baylibre.com \
    --cc=michal.simek@amd.com \
    --cc=ryder.lee@mediatek.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox