public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eugen Hristev <eugen.hristev@collabora.com>
To: Mihai Sain <mihai.sain@microchip.com>,
	Claudiu.Beznea@microchip.com, u-boot@lists.denx.de
Cc: Cristian.Birsan@microchip.com
Subject: Re: [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node
Date: Fri, 24 Feb 2023 14:30:22 +0200	[thread overview]
Message-ID: <b04cf412-e7ff-0d88-4f3c-0e96045c2014@collabora.com> (raw)
In-Reply-To: <20230223112858.1641-1-mihai.sain@microchip.com>

On 2/23/23 13:28, Mihai Sain wrote:
> The PMC_MCK1 clock id for the ebi node is 23.
> 
> Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>   arch/arm/dts/sama7g5.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
> index d38090d7dd..a802153af8 100644
> --- a/arch/arm/dts/sama7g5.dtsi
> +++ b/arch/arm/dts/sama7g5.dtsi
> @@ -150,7 +150,7 @@
>   				  0x1 0x0 0x48000000 0x8000000
>   				  0x2 0x0 0x50000000 0x8000000
>   				  0x3 0x0 0x58000000 0x8000000>;
> -			clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
> +			clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
>   			status = "disabled";
>   
>   			nand_controller: nand-controller {

Hi Mihai,

It appears PMC_MCK1 = PMC_MAIN(3) + 10 , in Linux.
In U-boot indeed it's 23.

Thanks for fixing it,

Reviewed-by: Eugen Hristev <eugen.hristev@collabora.com>

PS. I will amend the commit as it appears 4ce85577ac does not exist

  reply	other threads:[~2023-02-24 12:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 11:28 [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node Mihai Sain
2023-02-24 12:30 ` Eugen Hristev [this message]
2023-02-24 16:49 ` Claudiu.Beznea
  -- strict thread matches above, loose matches on Subject: below --
2023-02-23  9:12 Mihai Sain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b04cf412-e7ff-0d88-4f3c-0e96045c2014@collabora.com \
    --to=eugen.hristev@collabora.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Cristian.Birsan@microchip.com \
    --cc=mihai.sain@microchip.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox