public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node
@ 2023-02-23  9:12 Mihai Sain
  0 siblings, 0 replies; 4+ messages in thread
From: Mihai Sain @ 2023-02-23  9:12 UTC (permalink / raw)
  To: Claudiu.Beznea, Cristian.Birsan, u-boot; +Cc: Mihai Sain

The PMC_MCK1 clock id for the ebi node is 23.

Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
---
 arch/arm/dts/sama7g5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
index d38090d7dd..a802153af8 100644
--- a/arch/arm/dts/sama7g5.dtsi
+++ b/arch/arm/dts/sama7g5.dtsi
@@ -150,7 +150,7 @@
 				  0x1 0x0 0x48000000 0x8000000
 				  0x2 0x0 0x50000000 0x8000000
 				  0x3 0x0 0x58000000 0x8000000>;
-			clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
+			clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
 			status = "disabled";
 
 			nand_controller: nand-controller {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node
@ 2023-02-23 11:28 Mihai Sain
  2023-02-24 12:30 ` Eugen Hristev
  2023-02-24 16:49 ` Claudiu.Beznea
  0 siblings, 2 replies; 4+ messages in thread
From: Mihai Sain @ 2023-02-23 11:28 UTC (permalink / raw)
  To: eugen.hristev, Claudiu.Beznea, u-boot; +Cc: Cristian.Birsan, Mihai Sain

The PMC_MCK1 clock id for the ebi node is 23.

Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
---
 arch/arm/dts/sama7g5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
index d38090d7dd..a802153af8 100644
--- a/arch/arm/dts/sama7g5.dtsi
+++ b/arch/arm/dts/sama7g5.dtsi
@@ -150,7 +150,7 @@
 				  0x1 0x0 0x48000000 0x8000000
 				  0x2 0x0 0x50000000 0x8000000
 				  0x3 0x0 0x58000000 0x8000000>;
-			clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
+			clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
 			status = "disabled";
 
 			nand_controller: nand-controller {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node
  2023-02-23 11:28 [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node Mihai Sain
@ 2023-02-24 12:30 ` Eugen Hristev
  2023-02-24 16:49 ` Claudiu.Beznea
  1 sibling, 0 replies; 4+ messages in thread
From: Eugen Hristev @ 2023-02-24 12:30 UTC (permalink / raw)
  To: Mihai Sain, Claudiu.Beznea, u-boot; +Cc: Cristian.Birsan

On 2/23/23 13:28, Mihai Sain wrote:
> The PMC_MCK1 clock id for the ebi node is 23.
> 
> Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>   arch/arm/dts/sama7g5.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
> index d38090d7dd..a802153af8 100644
> --- a/arch/arm/dts/sama7g5.dtsi
> +++ b/arch/arm/dts/sama7g5.dtsi
> @@ -150,7 +150,7 @@
>   				  0x1 0x0 0x48000000 0x8000000
>   				  0x2 0x0 0x50000000 0x8000000
>   				  0x3 0x0 0x58000000 0x8000000>;
> -			clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
> +			clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
>   			status = "disabled";
>   
>   			nand_controller: nand-controller {

Hi Mihai,

It appears PMC_MCK1 = PMC_MAIN(3) + 10 , in Linux.
In U-boot indeed it's 23.

Thanks for fixing it,

Reviewed-by: Eugen Hristev <eugen.hristev@collabora.com>

PS. I will amend the commit as it appears 4ce85577ac does not exist

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node
  2023-02-23 11:28 [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node Mihai Sain
  2023-02-24 12:30 ` Eugen Hristev
@ 2023-02-24 16:49 ` Claudiu.Beznea
  1 sibling, 0 replies; 4+ messages in thread
From: Claudiu.Beznea @ 2023-02-24 16:49 UTC (permalink / raw)
  To: Mihai.Sain, eugen.hristev, u-boot; +Cc: Cristian.Birsan

On 23.02.2023 13:28, Mihai Sain wrote:
> The PMC_MCK1 clock id for the ebi node is 23.
> 
> Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  arch/arm/dts/sama7g5.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
> index d38090d7dd..a802153af8 100644
> --- a/arch/arm/dts/sama7g5.dtsi
> +++ b/arch/arm/dts/sama7g5.dtsi
> @@ -150,7 +150,7 @@
>  				  0x1 0x0 0x48000000 0x8000000
>  				  0x2 0x0 0x50000000 0x8000000
>  				  0x3 0x0 0x58000000 0x8000000>;
> -			clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
> +			clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
>  			status = "disabled";
>  
>  			nand_controller: nand-controller {


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-02-24 16:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-23 11:28 [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node Mihai Sain
2023-02-24 12:30 ` Eugen Hristev
2023-02-24 16:49 ` Claudiu.Beznea
  -- strict thread matches above, loose matches on Subject: below --
2023-02-23  9:12 Mihai Sain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox