Re: [PATCH 1/4] arm: bcmbca: add bcm63146 SoC support

[Florian Fainelli <f.fainelli@gmail.com>]

On 8/5/2022 6:34 PM, William Zhang wrote:
> BCM63146 is a Broadcom B53 based DSL Broadband SoC. It is part of the
> BCA (Broadband Carrier Access origin) chipset family so it's added under
> ARCH_BCMBCA platform. This initial support includes a bare-bone
> implementation and dts with CPU subsystem, memory and ARM PL011 uart.
> 
> This SoC is supported in the linux-next git repository so the dts and
> dtsi files are copied from linux.
> 
> The u-boot image can be loaded from flash or network to the entry point
> address in the memory and boot from there to the console.
> 
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---

[snip]

> +#include <common.h>
> +#include <asm/armv8/mmu.h>
> +#include <linux/sizes.h>
> +
> +static struct mm_region bcm963146_mem_map[] = {
> +		{
> +				.virt = 0x00000000UL,
> +				.phys = 0x00000000UL,
> +				.size = 1UL * SZ_1G,
> +				.attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) |
> +						PTE_BLOCK_INNER_SHARE
> +		},
> +		{

Should you create a mapping for the AXI bus portion at PA 0x81000000 
just so it is already in place for when you might need it?

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian