From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DD7DC00140 for ; Tue, 9 Aug 2022 03:24:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BFEB6845A3; Tue, 9 Aug 2022 05:24:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dO4bU0sC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C6498487F; Tue, 9 Aug 2022 05:24:51 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1A62E845A3 for ; Tue, 9 Aug 2022 05:24:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=f.fainelli@gmail.com Received: by mail-qt1-x82c.google.com with SMTP id j17so3139622qtp.12 for ; Mon, 08 Aug 2022 20:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=GFvmT0ZfzaSuPAyfWcyH0v0OTULre8vA5cWPdKiHkF4=; b=dO4bU0sCEkxR+gzADXXR9SoBPkvfUKkCatZHEpw5+zXEl0SUAtntzpOyEs+6gML0+N mCpVYosegi0nVKgklWoFJidg6LLvZJOIzE6e8w7DQvUErv0Sk6CyGYWkkJGt+logvuwf Eh0ErlLxeH06gxEqlhV3bke+IhQib+z01GxGwnmr6DXHJfxTloBGM6toUOSpyMw8TeaQ M9ti/DQsjcmxfd2EMKV51K5QQlzS8cBcGPdZMNiI9o+0N+ZOmvpoxEdzuUi7yO3OBRAW O6N5sALI8sqAWYhXTie2SlxCjl/fn626SI5dh0aiFDEx9ruzNzkwAZqi4lyovJlP3A7j 7NZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=GFvmT0ZfzaSuPAyfWcyH0v0OTULre8vA5cWPdKiHkF4=; b=pbFSbTj/DJmjp4SVFA10BmRM6HfEx35dnByxlHBL27xHIRlKS4coabYReZTlef/nOm T8CR54DJ7a8BU7r4hGfEkiw5qs4HrMZjnwfjj+YaNOcbdK8ob1TQeGl7/rA/jvWdR0hg Pg0IfD0x++valNpws//0l2OFMV4DY9IzRAD15osCRCEIcyQxPBMLIoqAtNr2mA6JG0W/ b800LNoGt0nI7GyCPs9XEtVo5kFCFPX6/IeOvBbMC1xklXkGXcqltBUxCRV8drYXkLaG 9UhJMw8mBaLZU2lck2TX5PwpmDy+GL75TOp64hM3FZ57FWTLYWmDLyGbxF9qhfJevTbg Va3w== X-Gm-Message-State: ACgBeo2LpTbqpn/WvG7JjbUKIKXOxhj+c/3BsKmvIdPxkzRqa7k5yg0u ibYXDuERPIj2BdAC6RVVKf8= X-Google-Smtp-Source: AA6agR4UWWZn4EF79Rf8CIpvdZjtRxhur7rCxx5Q7ENKYC9hZQ2t82AKytGvmM/bUEJ8KEpDhjuReg== X-Received: by 2002:ac8:4e91:0:b0:31f:cfa:7669 with SMTP id 17-20020ac84e91000000b0031f0cfa7669mr19102688qtp.264.1660015487779; Mon, 08 Aug 2022 20:24:47 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id bm32-20020a05620a19a000b006b8e63dfffbsm10676056qkb.58.2022.08.08.20.24.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 20:24:47 -0700 (PDT) Message-ID: Date: Mon, 8 Aug 2022 20:24:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Re: [PATCH 1/4] arm: bcmbca: add bcm63146 SoC support Content-Language: en-US To: William Zhang , U-Boot Mailing List Cc: kursad.oney@broadcom.com, dan.beygelman@broadcom.com, joel.peshkin@broadcom.com, philippe.reynes@softathome.com, rafal@milecki.pl, anand.gore@broadcom.com, Andre Przywara , Christian Hewitt , Fabio Estevam , Samuel Holland , Simon Glass , Tom Rini , Tomer Yacoby , "Ying-Chun Liu (PaulLiu)" References: <20220806013403.1344-1-william.zhang@broadcom.com> <20220805183208.1.I0f835c3d10199d90a76895915dd50be86ce9c820@changeid> From: Florian Fainelli In-Reply-To: <20220805183208.1.I0f835c3d10199d90a76895915dd50be86ce9c820@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/5/2022 6:34 PM, William Zhang wrote: > BCM63146 is a Broadcom B53 based DSL Broadband SoC. It is part of the > BCA (Broadband Carrier Access origin) chipset family so it's added under > ARCH_BCMBCA platform. This initial support includes a bare-bone > implementation and dts with CPU subsystem, memory and ARM PL011 uart. > > This SoC is supported in the linux-next git repository so the dts and > dtsi files are copied from linux. > > The u-boot image can be loaded from flash or network to the entry point > address in the memory and boot from there to the console. > > Signed-off-by: William Zhang > --- [snip] > +#include > +#include > +#include > + > +static struct mm_region bcm963146_mem_map[] = { > + { > + .virt = 0x00000000UL, > + .phys = 0x00000000UL, > + .size = 1UL * SZ_1G, > + .attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) | > + PTE_BLOCK_INNER_SHARE > + }, > + { Should you create a mapping for the AXI bus portion at PA 0x81000000 just so it is already in place for when you might need it? Reviewed-by: Florian Fainelli -- Florian