From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Walle Date: Tue, 11 Aug 2020 08:44:28 +0200 Subject: [PATCH] pci: layerscape: Fix spurious writes and panic In-Reply-To: <20200803221633.24096-1-michael@walle.cc> References: <20200803221633.24096-1-michael@walle.cc> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, Hi Priyanka, Am 2020-08-04 00:16, schrieb Michael Walle: > The fdt_fixup_pcie_ls() scans all PCI devices and assumes that all PCI > root devices are layerscape PCIe controllers. Unfortunately, this is > not > true for the LS1028A. There is one additional static PCI root complex > (this contains the networking devices) which has nothing to do with the > layerscape PCIe controllers. On recent U-Boot versions this results in > the following panic: > > "Synchronous Abort" handler, esr 0x96000044 > elr: 000000009602fa04 lr : 000000009602f9f4 (reloc) > elr: 00000000fbd73a04 lr : 00000000fbd739f4 > x0 : 0080000002000101 x1 : 0000000000000000 > x2 : 00000000fbde9000 x3 : 0000000000000001 > x4 : 0000000000000000 x5 : 0000000000000030 > x6 : 00000000fbdbd460 x7 : 00000000fbb3d3a0 > x8 : 0000000000000002 x9 : 000000000000000c > x10: 00000000ffffffe8 x11: 0000000000000006 > x12: 000000000001869f x13: 0000000000000a2c > x14: 00000000fbb3d2cc x15: 00000000ffffffff > x16: 0000000000010000 x17: 0000000000000000 > x18: 00000000fbb3fda0 x19: 0000000000000800 > x20: 0000000000000000 x21: 00000001f0000000 > x22: 0000000000000800 x23: 0000000000000009 > x24: 00000000fbdc3c1b x25: 00000000fbdc28e5 > x26: 00000000fbdcc008 x27: 00000000fbdc16e2 > x28: 000000000f000000 x29: 00000000fbb3d3a0 > > Code: 394072a1 f94006a0 34000041 5ac00a94 (b8336814) > Resetting CPU ... > > This bug already existed in former versions, but the spurious write was > never trapped, because the destination address was a valid address (by > pure luck). Can we get this into the -rc ? -michael